perf: use kareem 3.3.0 re: mongoosejs/kareem#45#16229
Open
perf: use kareem 3.3.0 re: mongoosejs/kareem#45#16229
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Mongoose’s Kareem dependency to pull in upstream performance improvements (mongoosejs/kareem#45), aiming to reduce overhead in common save flows and improve benchmark parity with the MongoDB Node driver.
Changes:
- Bump
kareemdependency from3.2.0to3.3.0.
hasezoey
approved these changes
Apr 14, 2026
Collaborator
hasezoey
left a comment
There was a problem hiding this comment.
Aside from some CI failing likely due to outdated github npm cache on some runners (notarget kareem@3.3.0), this LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pulling in changes from mongoosejs/kareem#45 - consistently trims 5-10% off of the
saveSimplebenchmark. Not a lot, but we're getting much closer to matching the MongoDB Node driver.Before:
After:
Examples