fix(schema): avoid throwing duplicate index error if index spec keys have different order or index has a custom name #15112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have different order or index has a custom name Fix #15109
hasezoey
approved these changes
Dec 17, 2024
Co-authored-by: hasezoey <hasezoey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15109
Summary
#15109 points out that if index spec has keys in different order, that is still valid. So
schema.index({ a: 1, b: 1 }); schema.index({ b: 1, a: 1 })should work. Also, if there is a custom indexname, then that is fine too, because MongoDB enforces index uniqueness based onname. It's just that two indexes with the same spec will have the samenameunless an explicitnameoption is specified in the index options.Examples