Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ChangeStream.close to return a Promise<void> like the driver #14740

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix ChangeStream.close to return a Promise<void> like the driver #14740

merged 1 commit into from
Jul 11, 2024

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Jul 11, 2024

Summary

Client code that calls stream.close().then(...) fails with TypeError, since mongoose close() returns undefined.

@orgads
Fix ChangeStream.close to return a Promise<void> like the driver
0fbe1d4 
Client code that calls stream.close().then(...) fails with TypeError,
since mongoose close() returns undefined.
vkarpov15
vkarpov15 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 8.5.1 milestone Jul 11, 2024
@vkarpov15 vkarpov15 merged commit 090297e into Automattic:master Jul 11, 2024
24 checks passed
@orgads orgads deleted the stream-close-promise branch July 11, 2024 16:30
@zntb zntb mentioned this pull request Aug 2, 2024
Merged
@saileshbro saileshbro mentioned this pull request Aug 2, 2024
Merged
This was referenced Aug 2, 2024
Merged
Merged
Merged
@WontonSam WontonSam mentioned this pull request Aug 3, 2024
Open
@saileshbro saileshbro mentioned this pull request Aug 3, 2024
Merged
@akanchhaS akanchhaS mentioned this pull request Aug 3, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Aug 3, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Aug 3, 2024
Open
@carltrepanier carltrepanier mentioned this pull request Aug 3, 2024
Merged
@NotZarifGithub NotZarifGithub mentioned this pull request Aug 3, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Aug 3, 2024
Open
@k2xl k2xl mentioned this pull request Aug 3, 2024
Closed
@WontonSam WontonSam mentioned this pull request Aug 3, 2024
Open
@axqqt axqqt mentioned this pull request Aug 3, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Aug 3, 2024
Open
This was referenced Aug 3, 2024
Open
Open
This was referenced Aug 4, 2024
Closed
Closed
@Erenkrs Erenkrs mentioned this pull request Aug 4, 2024
Open
@CarlosMHF CarlosMHF mentioned this pull request Aug 4, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Aug 5, 2024
Open
@tuanicom tuanicom mentioned this pull request Aug 5, 2024
Merged
@Gabo-Tech Gabo-Tech mentioned this pull request Sep 4, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Sep 4, 2024
Open
@lholmquist lholmquist mentioned this pull request Sep 4, 2024
Closed
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 4, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 4, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Sep 4, 2024
Open
This was referenced Sep 4, 2024
Open
Open
Open
@MihikaNigam MihikaNigam mentioned this pull request Sep 4, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 4, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Sep 6, 2024
Open
@GoGPenguin GoGPenguin mentioned this pull request Sep 6, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 6, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 6, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 7, 2024
Open
@IT21168222 IT21168222 mentioned this pull request Sep 7, 2024
Open
@axqqt axqqt mentioned this pull request Sep 7, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Sep 8, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 8, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Sep 9, 2024
Open
@aditya-arcot aditya-arcot mentioned this pull request Sep 9, 2024
Merged
This was referenced Sep 9, 2024
Open
Open
@Erenkrs Erenkrs mentioned this pull request Sep 9, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Sep 10, 2024
Open
@anandanshul anandanshul mentioned this pull request Sep 11, 2024
Open
This was referenced Sep 11, 2024
Open
Open
@pradumchintamani pradumchintamani mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@orgads @vkarpov15