-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types: avoid automatically inferring lean result type when assigning to explicitly typed variable #14734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to explicitly typed variable Fix #14697
hasezoey
approved these changes
Jul 10, 2024
This was referenced Sep 19, 2024
This was referenced Sep 19, 2024
This was referenced Sep 19, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14697
Summary
With the way that
lean()
is currently implemented, the following code unexpectedly compilesThat's because TypeScript automatically infers the generic param to
lean()
ifuser
has an explicit type.In order to support this, I needed to change the default value of
RawDocType
param toQuery<>
tounknown
. WhenRawDocType
was set toDocType
by default, that would break whenDocType
was set to be a hydrated document.Examples