-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(document): ensure post('deleteOne') hooks are called when calling save()
after subdoc.deleteOne()
#14732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `save()` after `subdoc.deleteOne()` Fix #9885
I also refactored the subdoc post save hook to use async/await. Looks to be about 7% faster on the We will do some work to add promise support for kareem, to avoid the need to explicitly instantiate |
This was referenced Jul 30, 2024
This was referenced Jul 30, 2024
This was referenced Sep 1, 2024
This was referenced Sep 3, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9885
Summary
It looks like when we removed
remove()
, we didn't make it so thatpost('deleteOne')
hooks fire when yousave()
a deleted doc. This PR makes Mongoose consistently trigger post('deleteOne') middleware on subdocs when you callsubdoc.deleteOne(); await topLevelDoc.save();
, which is what used to happen when you didsubdoc.remove(); await topLevelDoc.save();
Examples