Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: avoid inferring Boolean, Buffer, ObjectId as Date in schema definitions under certain circumstances #14667

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14630

Summary

#14630 pointed out that, under certain circumstances that I'm unable to quantify exactly, Boolean, mongoose.Schema.Types.ObjectId, and several other schema types get inferred as dates. This doesn't happen in tsd, or if Mongoose is symlinked into node_modules, so we can't write tests for this issue with our current testing setup.

I tracked the issue down to somehow typeof NativeDate catching Boolean and other data class types. This PR appears to fix the issue, and doesn't break any existing code that we're currently aware of.

Examples

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Jun 16, 2024
@vkarpov15 vkarpov15 added this to the 8.4.2 milestone Jun 17, 2024
@vkarpov15 vkarpov15 merged commit 332f7f5 into master Jun 17, 2024
5 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-14630 branch June 17, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript sees the Boolean Constructor Type as Date when using Mongoose
2 participants