Skip to content

types(DocumentArray): pass DocType generic to Document for correct toJSON() and toObject() return types #14526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2024
Merged

types(DocumentArray): pass DocType generic to Document for correct toJSON() and toObject() return types #14526

merged 1 commit into from
Apr 16, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14469

Summary

Due to missing generic, toObject() and toJSON() on array subdocs currently returns any.

Examples

@hasezoey hasezoey changed the title types(DocumentArray): pass DocType generic to Document for correct toSON() and toObject() return types types(DocumentArray): pass DocType generic to Document for correct toJSON() and toObject() return types Apr 15, 2024
@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Apr 15, 2024
@vkarpov15 vkarpov15 merged commit 0c5ec09 into master Apr 16, 2024
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-14469 branch April 16, 2024 15:02
@Marion-Rld Marion-Rld mentioned this pull request May 18, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request May 19, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 19, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request May 19, 2024
Open
@YohanChabiduPerera YohanChabiduPerera mentioned this pull request May 19, 2024
Open
@akanchhaS akanchhaS mentioned this pull request May 19, 2024
Open
@Erenkrs Erenkrs mentioned this pull request May 19, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request May 20, 2024
Open
@lholmquist lholmquist mentioned this pull request May 20, 2024
Closed
@James220903 James220903 mentioned this pull request May 20, 2024
Open
@Erenkrs Erenkrs mentioned this pull request May 20, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 20, 2024
Open
@tomlebl tomlebl mentioned this pull request May 21, 2024
Closed
@carltrepanier carltrepanier mentioned this pull request May 21, 2024
Merged
@OOCAZ OOCAZ mentioned this pull request May 21, 2024
Merged
This was referenced May 21, 2024
Merged
Merged
This was referenced May 21, 2024
Merged
Merged
@MihikaNigam MihikaNigam mentioned this pull request May 21, 2024
Open
@solitariusdigital solitariusdigital mentioned this pull request May 21, 2024
Closed
@akanchhaS akanchhaS mentioned this pull request May 21, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Jun 6, 2024
Open
@jasbleidysilva jasbleidysilva mentioned this pull request Jun 6, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Jun 6, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 6, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Jun 7, 2024
Open
@lholmquist lholmquist mentioned this pull request Jun 7, 2024
Closed
@NotZarifGithub NotZarifGithub mentioned this pull request Jun 7, 2024
Open
This was referenced Jun 7, 2024
Open
Open
@akanchhaS akanchhaS mentioned this pull request Jun 8, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Jun 8, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 8, 2024
Open
@DulranS DulranS mentioned this pull request Jun 8, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Jun 8, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 8, 2024
Open
@astitva3110 astitva3110 mentioned this pull request Jun 8, 2024
Open
This was referenced Jun 9, 2024
Open
Open
@koha2006-hue koha2006-hue mentioned this pull request Jun 12, 2024
Open
This was referenced Jun 12, 2024
Open
Open
@Mekdeskebede Mekdeskebede mentioned this pull request Jun 13, 2024
Open
@MinhhTien MinhhTien mentioned this pull request Jun 14, 2024
Closed
@slur96 slur96 mentioned this pull request Jun 14, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 15, 2024
Open
@global-tek global-tek mentioned this pull request Jun 15, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 16, 2024
Open
@malinanu malinanu mentioned this pull request Jun 16, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Jun 16, 2024
Open
@ashiq-firoz ashiq-firoz mentioned this pull request Jun 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type of subdocument not inferred in toJSON()
2 participants
@vkarpov15 @hasezoey