Forms: add number input #40962

simison · 2025-01-10T16:51:22Z

Issue #40961

Proposed changes:

Adds simple number field
No min/max/step attributes for now as those can be added in follow-up PR.
Input is quite wide in editor, but how forms layout/CSS is done doesn't make it straightforward to correct. Good for follow-up PR.

Allows setting placeholders as text — PR for general improvement for all fields in #41712:

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

In forms, add number input.
Try different default values; can be only numberic
Try different placeholders; can be numberic or text
Try submit the input with correct and incorrect information
Try hack the vlaues, should accept only numberic values
Try export values

Number needs to appear in several places after submitting:

Confirmation message

Email

Inbox

Export

github-actions · 2025-01-10T16:52:08Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/forms-number-input branch.
To test on Simple, run the following command on your sandbox:
```
bin/jetpack-downloader test jetpack add/forms-number-input
```

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-01-10T16:52:15Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2025-02-11T10:27:25Z

Code Coverage Summary

Coverage changed in 5 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form-field.php	342/507 (67.46%)	-1.16%	9 💔
projects/packages/forms/src/blocks/contact-form/class-contact-form-block.php	0/156 (0.00%)	0.00%	6 💔
projects/packages/forms/src/contact-form/class-contact-form.php	532/765 (69.54%)	-0.19%	3 ❤️‍🩹
projects/packages/forms/src/contact-form/class-contact-form-plugin.php	111/838 (13.25%)	-0.03%	2 ❤️‍🩹
projects/packages/forms/src/blocks/contact-form/child-blocks.js	0/65 (0.00%)	0.00%	1 ❤️‍🩹

Full summary · PHP report · JS report

simison · 2025-02-11T12:27:08Z

projects/packages/forms/src/blocks/contact-form/components/jetpack-field.js

@@ -52,7 +52,8 @@ const JetpackField = props => {
 					onChange={ e => setAttributes( { placeholder: e.target.value } ) }
 					style={ fieldStyle }
 					type={ type }
-					value={ placeholder }
+					value=""
+					placeholder={ placeholder }


PR in:

Forms: use a placeholder attribute in the editor instead of value #41712

simison added [Status] In Progress [Package] Forms [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. labels Jan 10, 2025

github-actions bot added [Block] AI Assistant [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Docs labels Jan 10, 2025

simison force-pushed the add/forms-number-input branch from 7b5380d to 975a521 Compare January 13, 2025 12:10

simison mentioned this pull request Jan 14, 2025

Forms: number field #40961

Open

3 tasks

simison force-pushed the add/forms-number-input branch from e7be37d to 2eac76d Compare February 11, 2025 10:17

simison mentioned this pull request Feb 11, 2025

Forms: fix error setting for field #41715

Open

3 tasks

simison commented Feb 11, 2025

View reviewed changes

simison marked this pull request as ready for review February 11, 2025 12:27

simison added [Status] Needs Team Review and removed [Status] In Progress [Block] AI Assistant labels Feb 11, 2025

github-actions bot added [Block] AI Assistant [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 11, 2025

simison added [Type] Feature Development of a new feature and removed [Block] AI Assistant [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 11, 2025

github-actions bot added the [Block] AI Assistant label Feb 11, 2025

simison added 4 commits February 11, 2025 14:30

Forms block: add number input

0caa8a3

changelog

3e8e013

Simplify and use number type

2a522dd

Add number field to grunion CSS

8f5707b

simison added 3 commits February 11, 2025 14:30

Render input on frontend

db2e500

Use real placeholder attribute in the editor

c799172

Remove number from get_field_ids

93c3317

simison force-pushed the add/forms-number-input branch from c1d6293 to 93c3317 Compare February 11, 2025 12:31

Move number out of beta

455280c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Forms: add number input #40962

Forms: add number input #40962

simison commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Feb 11, 2025 •

edited

Loading

simison Feb 11, 2025

Forms: add number input #40962

Are you sure you want to change the base?

Forms: add number input #40962

Conversation

simison commented Jan 10, 2025 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Jan 10, 2025 • edited Loading

github-actions bot commented Jan 10, 2025 • edited Loading

github-actions bot commented Feb 11, 2025 • edited Loading

Code Coverage Summary

simison Feb 11, 2025

Choose a reason for hiding this comment

simison commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Feb 11, 2025 •

edited

Loading