Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twenty Twenty: Update Jetpack compatibility #14175

Merged
merged 3 commits into from
Dec 6, 2019
Merged

Twenty Twenty: Update Jetpack compatibility #14175

merged 3 commits into from
Dec 6, 2019

Conversation

danieldudzic
Copy link
Contributor

@danieldudzic danieldudzic commented Dec 5, 2019 •
edited
Loading

Fix general Infinite Scroll compatibility issues, add support for Content Options and add misc styling fixes.

  • Add support for Content Options. You can test this via Cuzstomizer (https://jetpack.com/support/content-options/).

  • Add Infinite Scroll support Footer Widgets - If footer widgets are present, the scroll type will be set to click so the widgets are accessible.

  • Add support for the Social Menu (without output)

  • Fix Infinite Scroll sticky footer overlap issue with images

  • Fix margin issue for the Infinite Scroll button and spinner

  • Fix misc styling issues in widgets: Authors and Flickr

@danieldudzic danieldudzic requested a review from a team as a code owner December 5, 2019 00:39
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello danieldudzic! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D36261-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Dec 5, 2019 •
edited
Loading

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against b3e4abe

@jeherve jeherve added [Status] In Progress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Theme Tools labels Dec 5, 2019
@jeherve jeherve removed their request for review December 5, 2019 13:20
@matticbot
Copy link
Contributor

danieldudzic, Your synced wpcom patch D36261-code has been updated.

jeherve
jeherve requested changes Dec 5, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a bit more details to the PR description to explain what changes this introduces, and how to test them?

Thank you!

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] In Progress labels Dec 5, 2019
@jeherve jeherve added this to the 8.1 milestone Dec 5, 2019
@matticbot
Copy link
Contributor

danieldudzic, Your synced wpcom patch D36261-code has been updated.

@danieldudzic
Copy link
Contributor Author

danieldudzic commented Dec 5, 2019 •
edited
Loading

Hey @jeherve - I have now updated the initial comment with additional details.

Also, thanks for fixing PHPCS warnings!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Dec 6, 2019
jeherve
jeherve approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to test well for me. Merging now.

Add support for the Social Menu (without output)

Can you share a bit about your plans with this maybe?

@jeherve jeherve merged commit 2043615 into master Dec 6, 2019
@jeherve jeherve deleted the update/twentytwenty-jetpack-compat branch December 6, 2019 14:59
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Dec 6, 2019
jeherve added a commit that referenced this pull request Dec 13, 2019
@jeherve
Changelog: add #14175
074555d
zinigor added a commit that referenced this pull request Dec 30, 2019
@jeherve @zinigor
Changelog: 8.1 additions (#14166)
fff089c 
* Changelog: 8.1 additions

* Changelog: add #13858

* Changelog: add #13963

* Changelog: add #14174

* Changelog: add #14178

* Changelog: add #14175

* Changelog: add #14192

* Changelog: add #14196

* Changelog: add #14182

* Changelog: add #14218

* Changelog: add #14214

* Changelog: add #13757

* Changelog: add #14190

* Changelog: add #14131

* Changelog: add #14101

* Changelog: add #14203

* Changelog: add #14211

* Changelog: add #14224

* Changelog: add #14230

* Changelog: add #14241

* Changelog: add #14249

* Changelog: add #14264

* Changelog: add #14263

* Changelog: add #14256

* Changelog: add #10189

* Changelog: add #14240

* Changelog: add #14239

Also added some new entries to the testing file.

Co-authored-by: Igor Zinovyev <zinigor@gmail.com>
zinigor added a commit that referenced this pull request Dec 30, 2019
@jeherve @zinigor
Changelog: 8.1 additions (#14166)
d4a7565 
* Changelog: 8.1 additions

* Changelog: add #13858

* Changelog: add #13963

* Changelog: add #14174

* Changelog: add #14178

* Changelog: add #14175

* Changelog: add #14192

* Changelog: add #14196

* Changelog: add #14182

* Changelog: add #14218

* Changelog: add #14214

* Changelog: add #13757

* Changelog: add #14190

* Changelog: add #14131

* Changelog: add #14101

* Changelog: add #14203

* Changelog: add #14211

* Changelog: add #14224

* Changelog: add #14230

* Changelog: add #14241

* Changelog: add #14249

* Changelog: add #14264

* Changelog: add #14263

* Changelog: add #14256

* Changelog: add #10189

* Changelog: add #14240

* Changelog: add #14239

Also added some new entries to the testing file.

Co-authored-by: Igor Zinovyev <zinigor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@danieldudzic danieldudzic

Labels
[Feature] Theme Tools Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.
4 participants
@danieldudzic @matticbot @jetpackbot @jeherve