Build: Share babel config for client and extensions #11811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution: This PR has changes that must be merged to WordPress.com |
sirreal
added
[Status] In Progress
Admin Page
|
sirreal, Your synced wpcom patch D26314-code has been updated. |
sirreal
force-pushed
the
update/share-babel
branch
from
8658ba0 to
f6df322
Compare
This comment has been minimized.
This comment has been minimized.
sirreal
added
[Status] Needs Review
simison
reviewed
Apr 3, 2019
simison
reviewed
Apr 3, 2019
simison
reviewed
Apr 3, 2019
simison
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
My Babel knowledge isn't very deep but code looks good to me apart from open question about some plugins.
Builds blocks and admin panel well. 👍
|
Summarizing discussion: this is safe and ready 😎 |
kraftbj
approved these changes
Apr 3, 2019
kraftbj
added
[Status] Ready to Merge
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same babel config for the dashboard and for Gutenberg extensions.
The entire config will likely be replaced soon with a
calypso-buildprovided config.These specific transforms are removed:
@babel/transform-member-expression-literals@babel/transform-property-literals@babel/transform-reserved-wordsIt's unclear why they may have been necessary historically.
Required for #11812
Testing
wp.element.createElementfor JSX?