Update dependency mocha to v5 #10877

This release fixes a class of tests which report as false positives. Certain tests will now break, though they would have previously been reported as passing. Details below. Sorry for the inconvenience!

🐛 Fixes

#3226: Do not swallow errors that are thrown asynchronously from passing tests (@boneskull). Example:
```
it('should actually fail, sorry!', function (done) {
  // passing assertion
  assert(true === true);

  // test complete & is marked as passing
  done();

  // ...but something evil lurks within
  setTimeout(() => {
    throw new Error('chaos!');
  }, 100);
});
```
Previously to this version, Mocha would have silently swallowed the chaos! exception, and you wouldn't know. Well, now you know. Mocha cannot recover from this gracefully, so it will exit with a nonzero code.

Maintainers of external reporters: If a test of this class is encountered, the Runner instance will emit the end event twice; you may need to change your reporter to use runner.once('end') intead of runner.on('end').
#3093: Fix stack trace reformatting problem (@outsideris)

🔩 Other

#3248: Update browser-stdout to v1.3.1 (@honzajavorek)

`v5.0.1`

Compare Source

...your garden-variety patch release.

Special thanks to Wallaby.js for their continued support! ❤️

🐛 Fixes

#1838: --delay now works with .only() (@silviom)
#3119: Plug memory leak present in v8 (@boneskull)

📖 Documentation

#3132, #3098: Update --glob docs (@outsideris)
#3212: Update Wallaby.js-related docs (@ArtemGovorov)
#3205: Remove outdated cruft (@boneskull)

🔩 Other

#3224: Add proper Wallaby.js config (@ArtemGovorov)
#3230: Update copyright year (@josephlin55555)

`v5.0.0`

Compare Source

Mocha starts off 2018 right by again dropping support for unmaintained rubbish.

Welcome @vkarpov15 to the team!

💥 Breaking Changes

#3148: Drop support for IE9 and IE10 (@Bamieh)
Practically speaking, only code which consumes (through bundling or otherwise) the userland buffer module should be affected. However, Mocha will no longer test against these browsers, nor apply fixes for them.

🎉 Enhancements

#3181: Add useful new --file command line argument (documentation) (@hswolff)

🐛 Fixes

#3187: Fix inaccurate test duration reporting (@FND)
#3202: Fix bad markup in HTML reporter (@DanielRuf)

😎 Developer Experience

#2352: Ditch GNU Make for nps to manage scripts (@TedYav)

📖 Documentation

#3137: Add missing --no-timeouts docs (@dfberry)
#3134: Improve done() callback docs (@maraisr)
#3135: Fix cross-references (@vkarpov15)
#3163: Fix tpyos (@tbroadley)
#3177: Tweak README.md organization (@xxczaki)
Misc updates (@boneskull)

🔩 Other

#3118: Move TextMate Integration to its own repo (@Bamieh)
#3185: Add Node.js v9 to build matrix; remove v7 (@xxczaki)
#3172: Markdown linting (@boneskull)
Test & Netlify updates (@Munter, @boneskull)

`v4.1.0`

Compare Source

This is mainly a "housekeeping" release.

Welcome @Bamieh and @xxczaki to the team!

🐛 Fixes

#2661: progress reporter now accepts reporter options (@canoztokmak)
#3142: xit in bdd interface now properly returns its Test object (@Bamieh)
#3075: Diffs now computed eagerly to avoid misinformation when reported (@abrady0)
#2745: --help will now help you even if you have a mocha.opts (@Zarel)

🎉 Enhancements

#2514: The --no-diff flag will completely disable diff output (@CapacitorSet)
#3058: All "setters" in Mocha's API are now also "getters" if called without arguments (@makepanic)

📖 Documentation

#3170: Optimization and site speed improvements (@Munter)
#2987: Moved the old site repo into the main repo under docs/ (@boneskull)
#2896: Add maintainer guide (@boneskull)
Various fixes and updates (@xxczaki, @maty21, @leedm777)

🔩 Other

Test improvements and fixes (@eugenet8k, @ngeor, @38elements, @Gerhut, [@ScottFreeCode], @boneskull)
Refactoring and cruft excision (@38elements, @Bamieh, @finnigantime, @boneskull)

`v4.0.1`

Compare Source

🐛 Fixes

#3051: Upgrade Growl to v1.10.3 to fix its peer dep problems (@dpogue)

`v4.0.0`

Compare Source

You might want to read this before filing a new bug! 😝

💥 Breaking Changes

For more info, please read this article.

Compatibility

#3016: Drop support for unmaintained versions of Node.js (@boneskull):
- 0.10.x
- 0.11.x
- 0.12.x
- iojs (any)
- 5.x.x
#2979: Drop support for non-ES5-compliant browsers (@boneskull):
- IE7
- IE8
- PhantomJS 1.x
#2615: Drop Bower support; old versions (3.x, etc.) will remain available ([@ScottFreeCode], @boneskull)

Default Behavior

#2879: By default, Mocha will no longer force the process to exit once all tests complete. This means any test code (or code under test) which would normally prevent node from exiting will do so when run in Mocha. Supply the --exit flag to revert to pre-v4.0.0 behavior ([@ScottFreeCode], @boneskull)

Reporter Output

#2095: Remove stdout: prefix from browser reporter logs (@skeggse)
#2295: Add separator in "unified diff" output (@olsonpm)
#2686: Print failure message when --forbid-pending or --forbid-only is specified ([@ScottFreeCode])
#2814: Indent contexts for better readability when reporting failures (@charlierudolph)

👎 Deprecations

#2493: The --compilers command-line option is now soft-deprecated and will emit a warning on STDERR. Read this for more info and workarounds ([@ScottFreeCode], @boneskull)

🎉 Enhancements

#2628: Allow override of default test suite name in XUnit reporter (@ngeor)

📖 Documentation

#3020: Link to CLA in README.md and CONTRIBUTING.md (@skeggse)

🔩 Other

#2890: Speed up build by (re-)consolidating SauceLabs tests (@boneskull)

`v3.5.3`

Compare Source

🐛 Fixes

#3003: Fix invalid entities in xUnit reporter first appearing in v3.5.1 (@jkrems)

`v3.5.2`

Compare Source

🐛 Fixes

#3001: Fix AMD-related failures first appearing in v3.5.1 (@boneskull)

`v3.5.1`

Compare Source

📰 News

📣 Mocha is now sponsoring PDXNode! If you're in the Portland area, come check out the monthly talks and hack nights!

🐛 Fixes

#2997: Fix missing xit export for "require" interface (@solodynamo)
#2957: Fix unicode character handling in XUnit reporter failures (@jkrems)

🔩 Other

#2986: Add issue and PR templates (@kungapal)
#2918: Drop bash dependency for glob-related tests ([@ScottFreeCode])
#2922: Improve --compilers coverage ([@ScottFreeCode])
#2981: Fix tpyos and spelling errors (@jsoref)

`v3.5.0`

Compare Source

📰 News

Mocha now has a code of conduct (thanks @kungapal!).
Old issues and PRs are now being marked "stale" by Probot's "Stale" plugin. If an issue is marked as such, and you would like to see it remain open, simply add a new comment to the ticket or PR.
WARNING: Support for non-ES5-compliant environments will be dropped starting with version 4.0.0 of Mocha!

🔒 Security Fixes

#2860: Address CVE-2015-8315 via upgrade of debug (@boneskull)

🎉 Enhancements

#2696: Add --forbid-only and --forbid-pending flags. Use these in CI or hooks to ensure tests aren't accidentally being skipped! (@charlierudolph)
#2813: Support Node.js 8's --napi-modules flag (@jupp0r)

🔩 Other

Various CI-and-test-related fixes and improvements (@boneskull, [@dasilvacontin], @PopradiArpad, @Munter, [@ScottFreeCode])
"Officially" support Node.js 8 (@elergy)

`v3.4.2`

Compare Source

🐛 Fixes

#2802: Remove call to deprecated os.tmpDir (@makepanic)
#2820: Eagerly set process.exitCode (@chrisleck)

🔩 Other

#2807: Move linting into an npm script (@Munter)

`v3.4.1`

Compare Source

Fixed a publishing mishap with git's autocrlf settings.

`v3.3.0`

Compare Source

Thanks to all our contributors, maintainers, sponsors, and users! ❤️

As highlights:

We've got coverage now!
Testing is looking less flaky \o/.
No more nitpicking about "mocha.js" build on PRs.

🎉 Enhancements

#2659: Adds support for loading reporter from an absolute or relative path (@sul4bh)
#2769: Support --inspect-brk on command-line (@igwejk)

🐛 Fixes

#2662: Replace unicode chars w/ hex codes in HTML reporter (@rotemdan)

🔍 Coverage

#2672: Add coverage for node tests (@c089, @Munter)
#2680: Increase tests coverage for base reporter (@epallerols)
#2690: Increase tests coverage for doc reporter (@craigtaub)
#2701: Increase tests coverage for landing, min, tap and list reporters (@craigtaub)
#2691: Increase tests coverage for spec + dot reporters (@craigtaub)
#2698: Increase tests coverage for xunit reporter (@craigtaub)
#2699: Increase tests coverage for json-stream, markdown and progress reporters (@craigtaub)
#2703: Cover .some() function in utils.js with tests (@seppevs)
#2773: Add tests for loading reporters w/ relative/absolute paths (@sul4bh)

🔩 Other

Remove bin/.eslintrc; ensure execs are linted (@boneskull)
#2542: Expand CONTRIBUTING.md (@boneskull)
#2660: Double timeouts on integration tests (@Munter)
#2653: Update copyright year ([@Scottkao85], @Munter)
#2621: Update dependencies to enable Greenkeeper (@boneskull, @greenkeeper)
#2625: Use trusty container in travis-ci; use "artifacts" addon (@boneskull)
#2670: doc(CONTRIBUTING): fix link to org members (@coderbyheart)
Add Mocha propaganda to README.md (@boneskull)
#2470: Avoid test flake in "delay" test (@boneskull)
#2675: Limit browser concurrency on sauce (@boneskull)
#2669: Use temporary test-only build of mocha.js for browsers tests (@Munter)
Fix "projects" link in README.md (@boneskull)
#2678: Chore(Saucelabs): test on IE9, IE10 and IE11 (@coderbyheart)
#2648: Use semistandard directly (@kt3k)
#2727: Make the build reproducible (@lamby)

`v3.2.0`

Compare Source

📰 News

Mocha is now a JS Foundation Project!

Mocha is proud to have joined the JS Foundation. For more information, read the announcement.

Contributor License Agreement

Under the foundation, all contributors to Mocha must sign the JS Foundation CLA before their code can be merged. When sending a PR--if you have not already signed the CLA--a friendly bot will ask you to do so.

Mocha remains licensed under the MIT license.

🐛 Bug Fix

#2535: Fix crash when --watch encounters broken symlinks (@villesau)
#2593: Fix (old) regression; incorrect symbol shown in list reporter (@Aldaviva)
#2584: Fix potential error when running XUnit reporter (@vobujs)

🎉 Enhancement

#2294: Improve timeout error messaging (@jeversmann, @boneskull)
#2520: Add info about --inspect flag to CLI help (@ughitsaaron)

🔩 Other

#2570: Use karma-mocha proper (@boneskull)
Licenses updated to reflect new copyright, add link to license and browser matrix to README.md (@boneskull, [@ScottFreeCode], [@dasilvacontin])

Thanks to all our contributors, sponsors and backers! Keep on the lookout for a public roadmap and new contribution guide coming soon.

`v3.1.2`

Compare Source

🐛 Bug Fix

#2528: Recovery gracefully if an Error's stack property isn't writable (@boneskull)

`v3.1.1`

Compare Source

🐛 Bug Fix

#1417: Don't report done() was called multiple times when it wasn't (@frankleonrose)

🔩 Other

#2490: Lint with semistandard config (@makepanic)
#2525: Lint all .js files (@boneskull)
#2524: Provide workaround for developers unable to run browser tests on macOS Sierra (@boneskull)

`v3.1.0`

Compare Source

🎉 Enhancement

#2357: Support --inspect on command-line (@simov)
#2194: Human-friendly error if no files are matched on command-line (@Munter)
#1744: Human-friendly error if a Suite has no callback (BDD/TDD only) (@anton)

🐛 Bug Fix

#2488: Fix case in which variables beginning with lowercase "D" may not have been reported properly as global leaks (@JustATrick) 😆
#2465: Always halt execution in async function when this.skip() is called (@boneskull)
#2445: Exits with expected code 130 when SIGINT encountered; exit code can no longer rollover at 256 (@Munter)
#2315: Fix uncaught TypeError thrown from callback stack (@1999)
Fix broken only()/skip() in IE7/IE8 (@boneskull)
#2502: Fix broken stack trace filter on Node.js under Windows (@boneskull)
#2496: Fix diff output for objects instantiated with String constructor (more) (@boneskull)

`v3.0.2`

Compare Source

🐛 Bug Fix

#2424: Fix error loading Mocha via Require.js (@boneskull)
#2417: Fix execution of deeply nested describe.only() suites (@not-an-aardvark)
Remove references to json-cov and html-cov reporters in CLI (@boneskull)

`v3.0.1`

Compare Source

🐛 Bug Fix

#2406: Restore execution of nested describe.only() suites (@not-an-aardvark)

`v3.0.0`

Compare Source

💥 Breaking Changes

⚠️ Due to the increasing difficulty of applying security patches made within its dependency tree, as well as looming incompatibilities with Node.js v7.0, Mocha no longer supports Node.js v0.8.
⚠️ Mocha may no longer be installed by versions of npm less than 1.4.0. Previously, this requirement only affected Mocha's development dependencies. In short, this allows Mocha to depend on packages which have dependencies fixed to major versions (^).
.only() is no longer "fuzzy", can be used multiple times, and generally just works like you think it should. 😂
To avoid common bugs, when a test injects a callback function (suggesting asynchronous execution), calls it, and returns a Promise, Mocha will now throw an exception:
```
const assert = require('assert');

it('should complete this test', function (done) {
  return new Promise(function (resolve) {
    assert.ok(true);
    resolve();
  })
    .then(done);
});
```
The above test will fail with Error: Resolution method is overspecified. Specify a callback *or* return a Promise; not both..
When a test timeout value greater than 2147483648 is specified in any context (--timeout, mocha.setup(), per-suite, per-test, etc.), the timeout will be disabled and the test(s) will be allowed to run indefinitely. This is equivalent to specifying a timeout value of 0. See MDN for reasoning.
The dot reporter now uses more visually distinctive characters when indicating "pending" and "failed" tests.
Mocha no longer supports component.
The long-forsaken HTMLCov and JSONCov reporters--and any relationship to the "node-jscoverage" project--have been removed.
spec reporter now omits leading carriage returns (\r) in non-TTY environment.

🎉 Enhancements

#808: Allow regular-expression-like strings in --grep and browser's grep querystring; enables flags such as i for case-insensitive matches and u for unicode. ([@a8m])
#2000: Use distinctive characters in dot reporter; , will denote a "pending" test and ! will denote a "failing" test. (@elliottcable)
#1632: Throw a useful exception when a suite or test lacks a title. ([@a8m])
#1481: Better .only() behavior. ([@a8m])
#2334: Allow this.skip() in async tests and hooks. (@boneskull)
#1320: Throw a useful exception when test resolution method is overspecified. (@jugglinmike)
#2364: Support --preserve-symlinks. (@rosswarren)

🐛 Bug Fixes

#2259: Restore ES3 compatibility. Specifically, support an environment lacking Date.prototype.toISOString(), JSON, or has a non-standard implementation of JSON. ([@ndhoule], @boneskull)
#2286: Fix after() failing to execute if test skipped using this.skip() in beforeEach(); no longer marks the entire suite as "pending". ([@dasilvacontin], @boneskull)
#2208: Fix function name display in markdown and html (browser) reporters. ([@ScottFreeCode])
#2299: Fix progress bar in html (browser) reporter. (@AviVahl)
#2307: Fix doc reporter crashing when test fails. (@jleyba)
#2323: Ensure browser entry point (browser-entry.js) is published to npm (for use with bundlers). (@boneskull)
#2310: Ensure custom reporter with an absolute path works in Windows. (@silentcloud)
#2311: Fix problem wherein calling this.slow() without a value would blast any previously set value. (@boneskull)
#1813: Ensure Mocha's own test suite will run in Windows. (@tswaters, @TimothyGu, @boneskull)
#2317: Ensure all interfaces are displayed in --help on CLI. ([@ScottFreeCode])
#1644: Don't exhibit undefined behavior when calling this.timeout() with very large values (@callumacrae, @boneskull)
#2361: Don't truncate name of thrown anonymous exception. (@boneskull)
#2367: Fix invalid CSS. (@bensontrent)
#2401: Remove carriage return before each test line in spec reporter. (@Munter)

🔩 Other

Upgrade production dependencies to address security advisories (and because now we can): glob, commander, escape-string-regexp, and supports-color. (@boneskull, @RobLoach)
Add Windows to CI. (@boneskull, @TimothyGu)
Ensure appropriate engines field in package.json. (@shinnn, @boneskull)
#2348: Upgrade ESLint to v2 (@anthony-redfox)

We ❤️ our backers and sponsors!

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

jetpackbot · 2018-12-07T13:28:39Z

	Warnings
⚠️	"Testing instructions" are missing for this PR. Please add some
⚠️	"Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

oskosk

yarn test-client runs well

renovate bot requested a review from a team December 7, 2018 13:27

renovate bot added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial labels Dec 7, 2018

Update dependency mocha to v5

952e8ab

renovate bot force-pushed the renovate/mocha-5.x branch from cfd8879 to 952e8ab Compare December 7, 2018 14:01

oskosk approved these changes Dec 8, 2018

View reviewed changes

oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Dec 8, 2018

oskosk merged commit 4ad4c3a into master Dec 8, 2018

matticbot added the [Status] Needs Changelog label Dec 8, 2018

oskosk deleted the renovate/mocha-5.x branch December 8, 2018 14:13

ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 8, 2018

oskosk removed the [Status] Needs Changelog label Dec 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependency mocha to v5 #10877

Update dependency mocha to v5 #10877

renovate bot commented Dec 7, 2018

jetpackbot commented Dec 7, 2018

oskosk left a comment

Update dependency mocha to v5 #10877

Update dependency mocha to v5 #10877

Conversation

renovate bot commented Dec 7, 2018

Release Notes

🎉 Enhancements

🐛 Fixes

📖 Documentation

🔩 Other

🐛 Fixes

🎉 Enhancements

🐛 Fixes

📖 Documentation

🔩 Other

🐛 Fixes

📖 Documentation

🔩 Other

🐛 Fixes

🔒 Security Fixes

🔩 Other

🐛 Fixes

🔩 Other

🐛 Fixes

📖 Documentation

🔩 Other

💥 Breaking Changes

🎉 Enhancements

🐛 Fixes

😎 Developer Experience

📖 Documentation

🔩 Other

🐛 Fixes

🎉 Enhancements

📖 Documentation

🔩 Other

🐛 Fixes

💥 Breaking Changes

Compatibility

Default Behavior

Reporter Output

👎 Deprecations

🎉 Enhancements

📖 Documentation

🔩 Other

🐛 Fixes

🐛 Fixes

📰 News

🐛 Fixes

🔩 Other

📰 News

🔒 Security Fixes

🎉 Enhancements

🔩 Other

🐛 Fixes

🔩 Other

🎉 Enhancements

🐛 Fixes

🔍 Coverage

🔩 Other

📰 News

Mocha is now a JS Foundation Project!

Contributor License Agreement

🐛 Bug Fix

🎉 Enhancement

🔩 Other

🐛 Bug Fix

🐛 Bug Fix

🔩 Other

🎉 Enhancement

🐛 Bug Fix

🐛 Bug Fix

🐛 Bug Fix

💥 Breaking Changes

🎉 Enhancements

🐛 Bug Fixes

🔩 Other

Renovate configuration

jetpackbot commented Dec 7, 2018

oskosk left a comment

Choose a reason for hiding this comment