Skip to content

Commit a3a6725

Browse files
authored
Forms: fix dataviews paddings (#45824)
1 parent 6c0929e commit a3a6725

File tree

3 files changed

+17
-13
lines changed

3 files changed

+17
-13
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Significance: patch
2+
Type: changed
3+
4+
Forms: adjust dataviews paddings for consistent spacing with the header

projects/packages/forms/src/dashboard/components/layout/style.scss

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,6 @@ body.jetpack_page_jetpack-forms-admin {
7373
width: 100%;
7474
background: var(--wpds-color-bg-surface-neutral-strong, #fff);
7575
border-bottom: none;
76-
77-
@media (max-width: 782px) {
78-
padding: 12px 24px;
79-
}
8076
}
8177

8278
.admin-ui-page__header-subtitle {
@@ -86,5 +82,14 @@ body.jetpack_page_jetpack-forms-admin {
8682
line-height: 20px;
8783
}
8884

85+
// these overrides mimic the ones in new admin packages
86+
.dataviews-wrapper .dataviews-view-table tr td:first-child,
87+
.dataviews-wrapper .dataviews-view-table tr th:first-child {
88+
padding-inline-start: 20px;
89+
}
8990

91+
.dataviews-wrapper .dataviews-view-table tr td:last-child,
92+
.dataviews-wrapper .dataviews-view-table tr th:last-child {
93+
padding-inline-end: 20px;
94+
}
9095
}

projects/packages/forms/src/dashboard/inbox/style.scss

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,6 @@
109109
left: 0;
110110
background: var(--wpds-color-bg-surface-neutral-strong, #fff);
111111

112-
@media (max-width: 782px) {
113-
padding: 0 24px; // Match mobile padding
114-
}
115-
116112
// On small stacks, switch to column stacking
117113
flex-direction: row;
118114

@@ -149,12 +145,8 @@
149145
}
150146

151147
.jp-forms__inbox__filters-container:not(:empty) {
152-
padding-inline: 48px; // Match header padding
148+
padding-inline: 20px; // Match header padding
153149
padding-block: 12px;
154-
155-
@media (max-width: 782px) {
156-
padding-inline: 24px;
157-
}
158150
}
159151

160152
.jp-forms__inbox-response-name {
@@ -367,6 +359,9 @@
367359
position: fixed;
368360
bottom: 0;
369361

362+
// Match .admin-ui-page__header padding
363+
padding-inline: 20px;
364+
370365
// Compensation for the width of the sidebar
371366
// Set left position when auto-fold is not on the body element.
372367
// Adapted from https://github.com/WordPress/gutenberg/blob/4ea86f891145daa12c8b59b18f02fb9fc4d83c5a/packages/base-styles/_mixins.scss#L183-L218

0 commit comments

Comments
 (0)