Skip to content

Commit dfe1c6f

Browse files
committed
chore: Improve message for capitalizing pronoun I
Old message was "First-person singular pronouns must be capitalized." But English has two first-person singular pronouns: I & me. Only I is capitalized. I changed the message to "The first-person singular subject pronoun must be capitalized." "I" is also called the nomininative. I chose "subject" because it's a little less jargony for people less familiar with grammar and linguistics, and it's shorter when the message is already long.
1 parent 5ba32f0 commit dfe1c6f

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

harper-core/src/linting/capitalize_personal_pronouns.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ impl Linter for CapitalizePersonalPronouns {
2525
span: tok.span,
2626
lint_kind: LintKind::Capitalization,
2727
suggestions: vec![Suggestion::ReplaceWith(vec!['I'])],
28-
message: "First-person singular pronouns must be capitalized.".to_string(),
28+
message: "The first-person singular subject pronoun must be capitalized."
29+
.to_string(),
2930
priority: 31,
3031
});
3132
}

0 commit comments

Comments
 (0)