Merge pull request #1029 from hippietrail/adj-of-a-curation-2025-04-5

chore: "side of a" false positive

Author: elijah-potter

harper-core/src/linting/adjective_of_a.rs

@@ -9,6 +9,7 @@ const FALSE_POSITIVES: &[&str] = &[
     // Different valid constructions.
     "all",
     "emblematic",
+    "equivalent",
     "full",
     "inside",
     // "more" is tricky but it often seems correct and idiomatic.
@@ -21,6 +22,7 @@ const FALSE_POSITIVES: &[&str] = &[
     "bit",
     "bottom",
     "chance",
+    "derivative",
     "dream",
     "front",
     "half",
@@ -35,6 +37,7 @@ const FALSE_POSITIVES: &[&str] = &[
     "precision",
     // for "rid" I removed the `5` flag in `dictionary.dict``
     "shadow",
+    "side",
     "short",
     "something",
     "sound",
@@ -416,4 +419,33 @@ mod tests {
         // Present participles have properties of adjectives, nouns, and verbs
         assert_lint_count("That's the beginning of a conversation.", AdjectiveOfA, 0);
     }
+
+    #[test]
+    fn dont_flag_side() {
+        // Can be an adjective in e.g. "via a side door"
+        assert_lint_count(
+            "it hit the barrier on the side of a highway",
+            AdjectiveOfA,
+            0,
+        );
+    }
+
+    #[test]
+    fn dont_flag_derivative() {
+        // Adj: "a derivative story", Noun: "stocks and derivatives"
+        assert_lint_count(
+            "Techniques for evaluating the *partial derivative of a function",
+            AdjectiveOfA,
+            0,
+        )
+    }
+
+    #[test]
+    fn dont_flag_equivalent() {
+        assert_lint_count(
+            "Rust's equivalent of a switch statement is a match expression",
+            AdjectiveOfA,
+            0,
+        );
+    }
 }