fix: guard against null return from get_edit_post_link() and get_permalink() #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alink() In PHP 8.1+, passing null to htmlspecialchars_decode() throws a deprecation notice. This occurs when get_edit_post_link() or get_permalink() returns null (e.g., when the current user lacks permission to view edit links). The notification callbacks now check for null returns and exit early, preventing the deprecation notice from being triggered. This is preferable to sending incomplete notification emails without valid links. Also updates notification tests to set the current user before creating posts, ensuring get_edit_post_link() returns a valid URL. Fixes #771 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
GaryJones
added
the
type: maintenance
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the PHP 8.1+ deprecation notice caused by passing
nulltohtmlspecialchars_decode():This occurs in the notification callbacks when
get_edit_post_link()orget_permalink()returnsnull(e.g., when the current user lacks permission to view edit links, or during unit tests without a logged-in user).Changes
modules/notifications/notifications.php: Added null checks before callinghtmlspecialchars_decode(). If the edit link or permalink is null, the notification callback returns early rather than sending an incomplete email.tests/Integration/NotificationsTest.php: Updated tests to callwp_set_current_user()before creating posts, ensuringget_edit_post_link()returns a valid URL.Fixes #771
Test plan
🤖 Generated with Claude Code