chore: simplify ESLint config after eslint-plugin-wpvip fix #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the manual React plugin workaround that was needed due to a react-hooks flat config bug in @automattic/eslint-plugin-wpvip@1.0.0. The bug (Automattic/eslint-config-wpvip#228) caused ESLint 9 to fail because react-hooks used the legacy plugins array format. Now that v1.1.1 includes the fix, we can use the recommended config directly instead of manually importing React plugins. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
GaryJones
added
the
type: maintenance
Contributor
Author
|
Waiting on Automattic/eslint-config-wpvip#235 to be fixed so that the right formatting fixes can be applied, to pass the CI here. |
…ting The eslint-plugin-wpvip package incorrectly declares wp-prettier as a devDependency instead of a dependency. This causes eslint-plugin-prettier to resolve to regular prettier, which ignores the parenSpacing option needed for WordPress coding standards. This override forces the correct prettier version, fixing CI failures where spaces inside parentheses were being incorrectly flagged. Also fixes indentation issues now properly detected with wp-prettier. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
GaryJones
commented
Dec 18, 2025
Comment on lines
+9
to
+15
| "overrides": { | ||
| "@automattic/eslint-plugin-wpvip": { | ||
| "eslint-plugin-prettier": { | ||
| "prettier": "npm:wp-prettier@3.0.3" | ||
| } | ||
| } | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
While there were a few linting items to fix, this override avoids waiting for the upstream dependency to be updated.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@automattic/eslint-plugin-wpvipfrom^1.0.0to^1.1.1eslint.config.jsto useAutomatticPlugin.configs.recommendeddirectlyTest plan
npm run lint-jsruns without configuration errors🤖 Generated with Claude Code