You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merge pull request #100 from robertgoss/CrossComponentInheritance_msvc_warning
## Issues - #99
## Symptom
When compiling the c++ act bindings for a cross component interface project the visual studio compiler outputs warningsof the form:
```
typedef struct {
PAbstractCAMBase_GetLastErrorPtr m_Base_GetLastError;
PAbstractCAMBase_ReleaseInstancePtr m_Base_ReleaseInstance;
PAbstractCAMBase_AcquireInstancePtr m_Base_AcquireInstance;
PAbstractCAMBase_GetVersionPtr m_Base_GetVersion;
PAbstractCAMBase_GetSymbolLookupMethodPtr m_Base_GetSymbolLookupMethod;
} sAbstractCAMFunctionTableBase;
typedef struct : sAbstractCAMFunctionTableBase {
PAbstractCAMLinking_CreateLinkerPtr m_Linking_CreateLinker;
PAbstractCAMLinking_QueryStrategyPtr m_Linking_QueryStrategy;
} sAbstractCAMFunctionTableLinking;
```
## Problem
This appars to be the issue in https://developercommunity.visualstudio.com/content/problem/1034754/warning-c5208-a-c20-feature-occurs-when-compiling-1.html
In particular we define anonymous structs with member that are then typedefed
## Solution
We give a name to the function table structs based on the typedef name with "Struct" appended to make it unique.
## Verification
Recompiled bindings after the change with no warning. Tests to call the interface still pass.
0 commit comments