update Java demo with tutorial update #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retried the way to define endpoint by web.xml, use urlPatterns of WebServlet now
Collaborator
|
Hi guys, the very first thing I noticed here is that the PR was trying to merge the changes into |
petrbroz
reviewed
Jul 28, 2021
src/main/java/oss.java
Outdated
| BucketsApi bucketsApi = new BucketsApi(); | ||
|
|
||
| ApiResponse<Buckets> buckets = bucketsApi.getBuckets("us", 100, null, forgeOAuth, | ||
| ApiResponse<Buckets> buckets = bucketsApi.getBuckets("us", 100, "abc", forgeOAuth, |
Collaborator
There was a problem hiding this comment.
What does the "abc" parameter mean here? According to the docs, the 3rd param is:
Key to use as an offset to continue pagination This is typically the last bucket key found in a preceding GET buckets response
Author
There was a problem hiding this comment.
This issue is from the original version of JAVA tutorial. done. fixed.
petrbroz
reviewed
Jul 28, 2021
Collaborator
petrbroz
left a comment
petrbroz
left a comment
There was a problem hiding this comment.
Apart from the "abc" thing the code looks good.
petrbroz
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the most change is : retried the way to define endpoint by web.xml, use urlPatterns of WebServlet now