Fix to map members of the generic type definition during expression mapping #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n mapping. 2) Using VisitUnary and VisitLambda instead of ArgumentMappers . 3) Added temporary fix for MemberAccesses issue in AutoMapper until Automapper isse 2704 gets resolved.
|
@jbogard - if you approve can you do a nuget upgrade please? |
|
@BlaiseD you've got merge and tag rights :) all you need to do to update nuget is tag the commit you want to release with a |
|
ok - got it. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for mapping expressions between members of a generic type definition is different because type maps do not exist.
e.g. mapping an expression with
IGrouping<int, User>.KeytoIGrouping<int, UserModel>.KeyorIGrouping<int, User>.ValuetoIGrouping<int, UserModel>.Valueneeded additional handling.