Fix enumerator not disposed when arbitrary projection is enumerated #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlaiseD
requested changes
Feb 21, 2022
|
@BlaiseD Thanks for your response. As mentioned in the PR description, I need an assist to build this project first. |
The CI and Release builds work - maybe do a web search for the issue you're running into? |
Let's `foreach` the enumerable, which automatically disposes enumerator.
|
@BlaiseD I have added the test. |
BlaiseD
approved these changes
Feb 22, 2022
|
Thanks |
|
Regarding the backport request to 4.x, should I submit a separate PR or will you handle that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
Let's directly
foreachthe enumerable, which automatically disposes the enumerator.I have added a test which fails for v5.0.0 (and v4.1.3) and passes with the new changes:
Should_dispose_enumerator_when_arbitrary_projection_is_enumeratedBackport request
Kindly backport to 4.x, so that this can be used in the same project that depends on AutoMapper.Collection, which does not support AutoMapper 11.x.
Reference: AutoMapper/AutoMapper.Collection#162