Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Extending Logger #378

Open
joshuadwire opened this issue Sep 12, 2019 · 2 comments
Open

Support Extending Logger #378

joshuadwire opened this issue Sep 12, 2019 · 2 comments

Comments

@joshuadwire
Copy link

I'd like to integrate the SDK with my existing logging framework rather than having it log directly to a file.

I think the easiest way to support this would be to modify the LogFactory class to support either setting the logger or setting the log class.

It would also be very helpful for the existing Log class to have most of the methods be protected instead of private so it can be extended more easily.

Thoughts on this implementation? I'd be glad to submit a pull request if that will help.

@abishekrsrikaanth
Copy link

I feel a better implementation would be to use https://github.com/Seldaek/monolog that allows specifying your own handler irrespective of what the SDK uses,

@joshuadwire
Copy link
Author

@abishekrsrikaanth I agree. Using Monolog would be best, but I'd be happy with anything that lets me override the logging functionality without using Reflection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants