Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpClient needs to accept options #276

Open
peledies opened this issue Dec 11, 2017 · 2 comments
Open

HttpClient needs to accept options #276

peledies opened this issue Dec 11, 2017 · 2 comments
Labels
sdk-enhancement Enhancement to SDK

Comments

@peledies
Copy link

sdk-php/lib/net/authorize/util/HttpClient.php is not configurable from what I can tell.

it would be nice to be able to add curl options to the request, specifically to specify the ssl version.

curl_setopt($curl_request, CURLOPT_SSL_VERIFYHOST, 2);

Similar to the way the Stripe SDK works, Example:

\Stripe\ApiRequestor::setHttpClient(
    new \Stripe\HttpClient\CurlClient(
        [ CURLOPT_SSLVERSION => CURL_SSLVERSION_TLSv1_2 ]
    )
);
@britbarn
Copy link

britbarn commented Feb 8, 2018

Agreed that this would be nice to have. Updating linux might not be able to happen in some cases.

@ashtru
Copy link
Contributor

ashtru commented Mar 26, 2018

Thanks @peledies, this looks like a good feature to have.
We can have a look into adding this configuration in the SDK.

@ashtru ashtru added the sdk-enhancement Enhancement to SDK label Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk-enhancement Enhancement to SDK
Development

No branches or pull requests

3 participants