-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various comment reply fixes (muting/reporting) #10096
Conversation
…es out of replies
…jd/mute-and-report-fixes
|
…jd/mute-and-report-fixes # Conflicts: # packages/discovery-provider/src/queries/get_comments.py
Preview this change https://demo.audius.co/jd/mute-and-report-fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff!
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11648680 | Triggered | Generic High Entropy Secret | b9c4781 | dev-tools/templates/test-localhost.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Preview this change https://demo.audius.co/jd/mute-and-report-fixes |
[528102b] Fix discovery comment notifications (#10119) Dylan Jeffers [52166e8] [C-5183, C-5190] Refactor comment notifications (#10092) Dylan Jeffers [40cdc8f] Fix get new blasts endpoint sql error (#10109) Reed [761524e] Various comment reply fixes (muting/reporting) (#10096) JD Francis [e488758] [C-5203] Fix comment unpin (#10102) Dylan Jeffers [178f051] Update UDR to match specification (#10098) Raymond Jacobson
[6240380] Fix comment notification data (#10123) Dylan Jeffers [8c9b00b] [QA-1737] Center user links in collection and user cards (#10122) Dylan Jeffers [109abfa] [C-5197] Fix native comment show more/less collapse (#10121) Dylan Jeffers [c971230] [C-5212] Open comment drawer from empty state (#10117) Sebastian Klingler [528102b] Fix discovery comment notifications (#10119) Dylan Jeffers [9fe6c66] [PAY-3522] Hides keyboard when opening purchase drawer from a DM (#10116) Randy Schott [69e73dd] Re-land changes to fix RN on xcode 16 (#10108) Randy Schott [906dc0b] [QA-1773] Fix corner overflow on GiantTrackTile (#10110) Andrew Mendelsohn [7f97ca2] [C-5209] Missing $ on downloads button (#10111) Andrew Mendelsohn [b3e1982] Drop Android InputAccessoryView (#10107) Dylan Jeffers [9bd3d6c] [C-5189] Fix mobile web skeletons (#10106) JD Francis [ee775d1] Fix mobile cursor position (#10104) Dylan Jeffers [761524e] Various comment reply fixes (muting/reporting) (#10096) JD Francis [98e7bd5] Add CommentDrawerContext to manage drawer state with navigation (#10103) Sebastian Klingler [e488758] [C-5203] Fix comment unpin (#10102) Dylan Jeffers [e8cdd08] Update mobile versions to 119 (#10101) Dylan Jeffers [966246f] [C-5137] Set android cursor position when replying/editing (#10091) Sebastian Klingler [127070e] Revert "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) Marcus Pasell [a921f74] [C-5112] Dismiss keyboard when pressing in comment drawer (#10093) Sebastian Klingler [d65ce1f] Improve mobile composer input render perf (#10095) Raymond Jacobson [2b0c76c] [PAY-3525] Fix text overflow (#10072) Farid Salau [ddd3f94] Fix chat header too long on mobile (#10089) Reed [42553e6] [PAY-3507] Skeleton for profile dms button (#10090) Andrew Mendelsohn [abf3634] Update DN to use shortened rewards challenge IDs and specifiers (#9803) Marcus Pasell [4b293d8] [C-5193] Add cancel button to comment replies and edits (#10080) Kyle Shanks [c5fd316] [C-5191] Add background color to comment cancel accessory view (#10078) Kyle Shanks [2f3b7ab] [PAY-3456] Fix chat last message sometimes wrong (#10084) Reed [0ac87a0] [PAY-3519] Fix mobile ChatBlastSubHeader opacity (#10079) Reed [9f3804b] Fix android animated icons (#10085) Dylan Jeffers [c0eca98] [PAY-3526] Hide scroll on message inbox (#10083) Farid Salau [f580ff7] [PAY-3509] Show InboxUnavailableModal instead of disabled button (#10081) Andrew Mendelsohn [3ae1af1] [PAY-3521] Fix offset calculation for Blast CTA (#10076) Andrew Mendelsohn [814fa37] Highlight user mentions when editing comments on web (#10077) Kyle Shanks [3144eac] [PAY-3424] Restrict imports from SDK 'dist' folder in client code (#10043) Randy Schott [8aa7242] [PAY-3523] Fix bug where share to DM persists in input (#10070) Raymond Jacobson [9812ee2] Update dapp-store build artifacts audius-infra [bfd21d8] Fix mobile lint (#10071) Raymond Jacobson [55c22f4] [PAY-3466] Improve composer input responsiveness on mobile (#10066) Raymond Jacobson [3c0ce0f] [QA-1762] Fix desktop app support on MacOS Sequoia (#10059) Raymond Jacobson [af09710] [C-5167] Improve mobile comments perf (#10067) Sebastian Klingler [29e9b01] [C-5178] Show newlines in comments (#10065) Isaac Solo [61e8734] Fix comment unauthed state (#10061) JD Francis [d355040] Fix lint (#10064) Andrew Mendelsohn [7023824] [PAY-3520] Fix error on blast analytics (#10063) Andrew Mendelsohn [4588410] [C-5166] [C-5108] [C-5156] Address comment QA issues (#10047) Sebastian Klingler [7494a1a] [PAY-3437] Add names to chats sentry reports (#10049) Reed [856d223] [PAY-3347] Analytics for create chat blast funnel (#10053) Andrew Mendelsohn [6401b5c] [PAY-3483] Update 'ChatListBlastItem' UI on smaller screens (#10057) Farid Salau [058e233] [C-5172] Fix comments timezone (#10052) Isaac Solo [7ce770c] [C-5155] Add cancel accessory to mobile ComposerInput for comments (#10058) Kyle Shanks [f992ddb] [C-5173] Fix sort by top comments out of date (#10055) JD Francis [bf6b4a8] [C-5184] Add border to Harmony PopoverMenu (#10050) Kyle Shanks [c1a5488] [C-5161 C-5151] Improve desktop track page responsiveness (#10040) Dylan Jeffers [5de96ce] [C-5141] Generate comment id in onMutate (#10031) Dylan Jeffers [db3f11a] [⚠️ ] Separate SDK and legacy libs (#9972) Raymond Jacobson [e01490c] Fix withdrawals not showing coinflow modal (#10051) Marcus Pasell [1cce513] Remove follows you badge from comment settings (#10024) Isaac Solo [cb76182] [C-5165] Update comment notifications to open the comment drawer (#10039) Dylan Jeffers [7e7acc9] [QA-1761] Fix mobile profile page username spacing (#10038) Dylan Jeffers [59a1d97] [C-5040] Enable animated mobile icons (#10037) Dylan Jeffers [4d09265] [C-5164] Add max height to mobile ComposerInput (#10044) Kyle Shanks [7d7008c] [C-5153] Update ComposerInput to not render the display layer unless there is highlighted text (#10042) Kyle Shanks [e72e207] Upgrade mobile version to 1.1.118 (#10035) Dylan Jeffers
Description
Started with a simple task and ended up tackling a ton of stuff
Other fixes
currentUserId
where comments data could get loaded with anundefined
user id (and get cached)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.