Fix migrations (#579)

Author: raymondjacobson

ddl/functions/compute_user_score.sql

@@ -16,9 +16,9 @@ create or replace function compute_user_score(
         chat_block_count bigint,
         following_count bigint,
         is_audius_impersonator boolean,
+        has_profile_picture boolean,
         distinct_tracks_played bigint,
-        karma bigint,
-        has_profile_picture boolean
+        karma bigint
     ) returns bigint as $$
 select (play_count / 2) + follower_count - challenge_count - (chat_block_count * 100) + karma + case
         when following_count < 5 then -1

ddl/functions/get_user_score.sql

@@ -1,6 +1,5 @@
 -- identical to get_user_scores but for a single user
 -- used to generate a user score for attestations and in UI tool
-drop function if exists get_user_score(integer);
 create or replace function get_user_score(target_user_id integer) returns table(
         -- order matters
         user_id integer,
@@ -12,6 +11,7 @@ create or replace function get_user_score(target_user_id integer) returns table(
         follower_count bigint,
         chat_block_count bigint,
         is_audius_impersonator boolean,
+        has_profile_picture boolean,
         karma bigint,
         score bigint
     ) language sql as $function$ with play_activity as (
@@ -54,7 +54,6 @@ create or replace function get_user_score(target_user_id integer) returns table(
             coalesce(au.following_count, 0) as following_count,
             coalesce(au.follower_count, 0) as follower_count,
             coalesce(cb.block_count, 0) as chat_block_count,
-            (u.profile_picture_sizes is not null) as has_profile_picture,
             case
                 when (
                     u.handle_lc ilike '%audius%'
@@ -63,6 +62,7 @@ create or replace function get_user_score(target_user_id integer) returns table(
                 and u.is_verified = false then true
                 else false
             end as is_audius_impersonator,
+            (u.profile_picture_sizes is not null) as has_profile_picture,
             case
                 when (
                     -- give max karma to users with more than 1000 followers
@@ -100,9 +100,9 @@ select a.*,
         a.chat_block_count,
         a.following_count,
         a.is_audius_impersonator,
+        a.has_profile_picture,
         a.distinct_tracks_played,
-        a.karma,
-        a.has_profile_picture
+        a.karma
     ) as score
 from aggregate_scores a;
 $function$;

ddl/functions/get_user_scores.sql

@@ -1,7 +1,6 @@
 -- identical to get_user_score but for a user batch
 -- used for updating score in aggregate_user
 -- this score is used in shadowbanning
-drop function if exists get_user_scores(integer []);
 create or replace function get_user_scores(
         target_user_ids integer [] default null::integer []
     ) returns table(
@@ -14,6 +13,7 @@ create or replace function get_user_scores(
         challenge_count bigint,
         chat_block_count bigint,
         is_audius_impersonator boolean,
+        has_profile_picture boolean,
         karma bigint,
         score bigint
     ) language sql as $function$ with play_activity as (
@@ -63,7 +63,6 @@ create or replace function get_user_scores(
             coalesce(aggregate_user.follower_count, 0) as follower_count,
             coalesce(fast_challenge_completion.challenge_count, 0) as challenge_count,
             coalesce(chat_blocks.block_count, 0) as chat_block_count,
-            (users.profile_picture_sizes is not null) as has_profile_picture,
             case
                 when (
                     users.handle_lc ilike '%audius%'
@@ -72,6 +71,7 @@ create or replace function get_user_scores(
                 and users.is_verified = false then true
                 else false
             end as is_audius_impersonator,
+            (users.profile_picture_sizes is not null) as has_profile_picture,
             case
                 when (
                     -- give max karma to users with more than 1000 followers
@@ -112,9 +112,9 @@ select a.*,
         a.chat_block_count,
         a.following_count,
         a.is_audius_impersonator,
+        a.has_profile_picture,
         a.distinct_tracks_played,
-        a.karma,
-        a.has_profile_picture
+        a.karma
     ) as score
 from aggregate_scores a;
 $function$;