Add UploadNodes to control uploads more tightly (#559)

Creates a configurable list of nodes that will be used for uploads (as
they are returned by health_check)

Keeps existing health monitoring for all nodes, just filters at the end.
A "smarter" method might be filtering _before_ tracking health, but this
gets the job done for now. Opted to do the filtering outside of the
monitor as it might be confusing why it only has a small number of nodes
it thinks are "healthy".

Notably still might be a footgun, as it's not obvious that health check
would be limited to the UploadNodes

Author: rickyrombo

api/health_check.go

@@ -2,6 +2,7 @@ package api
 
 import (
 	"context"
+	"slices"
 
 	core_indexer "api.audius.co/indexer"
 	"connectrpc.com/connect"
@@ -64,11 +65,14 @@ func (app *ApiServer) healthCheck(c *fiber.Ctx) error {
 
 	healthyNodes := app.contentNodeMonitor.GetContentNodes()
 	// Convert config.Node to contentNode
-	contentNodes := make([]contentNode, len(healthyNodes))
-	for i, node := range healthyNodes {
-		contentNodes[i] = contentNode{
-			DelegateOwnerWallet: node.DelegateOwnerWallet,
-			Endpoint:            node.Endpoint,
+	contentNodes := make([]contentNode, 0, len(healthyNodes))
+	for _, node := range healthyNodes {
+		// icky reaching into config to check upload nodes
+		if slices.Contains(app.contentNodeMonitor.config.UploadNodes, node.Endpoint) {
+			contentNodes = append(contentNodes, contentNode{
+				DelegateOwnerWallet: node.DelegateOwnerWallet,
+				Endpoint:            node.Endpoint,
+			})
 		}
 	}
 

config/config.go

@@ -27,6 +27,7 @@ type Config struct {
 	ArtistCoinRewardsStaticSenders []Node
 	StoreAllNodes                  []string
 	DeadNodes                      []string
+	UploadNodes                    []string
 	VerifierAddress                string
 	DelegatePrivateKey             string
 	AxiomToken                     string
@@ -106,6 +107,7 @@ func init() {
 		Cfg.SolanaIndexerWorkers = 1
 		Cfg.DeadNodes = []string{}
 		Cfg.StoreAllNodes = []string{}
+		Cfg.UploadNodes = DevUploadNodes
 		Cfg.AudiusdChainID = core_config.DevAcdcChainID
 		Cfg.AudiusdEntityManagerAddress = core_config.DevAcdcAddress
 		Cfg.AudiusAppUrl = "http://localhost:3000"
@@ -124,6 +126,7 @@ func init() {
 		Cfg.Nodes = StageNodes
 		Cfg.DeadNodes = []string{}
 		Cfg.StoreAllNodes = []string{}
+		Cfg.UploadNodes = StageUploadNodes
 		Cfg.Rewards = core_config.MakeRewards(core_config.StageClaimAuthorities, core_config.StageRewardExtensions)
 		Cfg.AudiusdURL = "creatornode11.staging.audius.co"
 		Cfg.ChainId = "audius-testnet-alpha"
@@ -169,6 +172,7 @@ func init() {
 		Cfg.StoreAllNodes = []string{
 			"https://creatornode2.audius.co",
 		}
+		Cfg.UploadNodes = ProdUploadNodes
 		Cfg.Rewards = core_config.MakeRewards(core_config.ProdClaimAuthorities, core_config.ProdRewardExtensions)
 		Cfg.AudiusdURL = "creatornode.audius.co"
 		Cfg.ChainId = "audius-mainnet-alpha-beta"

config/nodes.go

@@ -184,4 +184,16 @@ var (
 			OwnerWallet:         "0xCBB025e7933FADfc7C830AE520Fb2FD6D28c1065",
 		},
 	}
+
+	ProdUploadNodes = []string{
+		"https://creatornode.audius.co",
+		"https://creatornode2.audius.co",
+		"https://creatornode3.audius.co",
+	}
+	StageUploadNodes = []string{
+		"https://creatornode6.staging.audius.co",
+	}
+	DevUploadNodes = []string{
+		"http://audius-creator-node-1",
+	}
 )