Skip to content

Add public on some visualizations views #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Conversation

ipodishima
Copy link
Contributor

Motivation:

I'm working on some recording visualizations and discovered:

  • SpectrogramView initializer was not public
  • NodeRollingView could benefit from more control on configuration for reuse.
  • Opened FloatPlot and FragmentBuilder so that people could their own components based on those two

@aure aure merged commit ea3b8d8 into AudioKit:main Sep 29, 2022
@aure
Copy link
Member

aure commented Sep 29, 2022

Thanks!

@Matt54
Copy link
Member

Matt54 commented Oct 4, 2022

@ipodishima - do those colors in the SpectrogramView need to be Bindings? My guess is that they can just be variables (not State or Binding)

@Matt54
Copy link
Member

Matt54 commented Oct 4, 2022

Let me know if I'm off on this: #63

@ipodishima
Copy link
Contributor Author

Those were states before, this is why I kept bindings. But I'm not sure this is useful even though it's not lost to have bindings @Matt54

@Matt54
Copy link
Member

Matt54 commented Oct 5, 2022

@ipodishima I'm pretty sure I made them state when I had a "less than ideal" understanding of SwiftUI state management 😅 - I should probably do a full sweep through AudioKitUI and clean up my mess

@ipodishima
Copy link
Contributor Author

ipodishima commented Oct 10, 2022

Ahahaha no worries. I'm still trying to figure out the best practices for SwiftUI without being redundant, creating bugs, or having performance issues 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants