This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Work around bug in phpcs outputting invalid JSON #144
Closed
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catrope
force-pushed
the
work-around-phpcs-969
branch
from
fe44f32
to
9a36510
Compare
|
Hmmmm, I don't really like the idea of fixing this here, but on the other hand |
| @@ -135,6 +135,8 @@ module.exports = | |||
| if confFile then execOptions.cwd = path.dirname(confFile) | |||
| return helpers.exec(command, parameters, execOptions).then (result) => | |||
| try | |||
| # Strip time+memory information at the end; workaround for https://github.com/squizlabs/PHP_CodeSniffer/issues/969 | |||
There was a problem hiding this comment.
Can you add a # FIXME: Remove when the above issue is fixed (Or below, I don't really care which).
Just to make it explicit that this is something that should be removed as soon as we can do so.
|
It turns out I'm an idiot and had phpcs's behavior is still weird in that it only adds this information if no errors were found (and doesn't if errors were found), but I can't blame it too much for putting in this information if my config file asks for ut, |
|
Ha! Glad you found it 😆 |
weirdan
added a commit
to weirdan/linter-phpcs
that referenced
this pull request
Dec 16, 2016
This forces phpcs to not print neither totals nor progress even if config specifies -p (progress) option. Will work with phpcs 2.6.2 and newer. Several people reported problems with superfluous phpcs output, see AtomLinter#95 and AtomLinter#144.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See squizlabs/PHP_CodeSniffer#969
This is causing Atom to show an error every time I save a file
with no phpcs errors.