Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undefined id and disable button when no mats #274

Merged
merged 3 commits into from
Jul 20, 2024
Merged

fix: undefined id and disable button when no mats #274

merged 3 commits into from
Jul 20, 2024

Conversation

Jayllyz
Copy link
Contributor

@Jayllyz Jayllyz commented Jul 20, 2024 •
edited
Loading

Summary 📝

Which part of the repository is impacted ?

  • API
  • Client
  • Admin
  • Documentation
  • CI/CD
  • Other

Test plan 🧪

Screenshots (if appropriate): 📸

@Jayllyz Jayllyz self-assigned this Jul 20, 2024
@github-actions github-actions bot added the fix label Jul 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 20, 2024 •
edited
Loading

Coverage Report for API (./apps/api)

Status Category Percentage Covered / Total
🟢 Lines 89.25% (🎯 80%) 6847 / 7671
🟢 Statements 89.25% (🎯 80%) 6847 / 7671
🟢 Functions 100% (🎯 60%) 24 / 24
🟢 Branches 46.89% (🎯 35%) 279 / 595
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/api/src/handlers/materials.ts 92.45% 71.42% 100% 92.45% 37-38, 59-60, 113-114, 134-135, 169-170, 185-186
apps/api/src/routes/materials.ts 100% 100% 100% 100%
Generated in workflow #474

@userMeh userMeh merged commit 0d1d8d8 into main Jul 20, 2024
6 checks passed
@userMeh userMeh deleted the fix/materials-issue branch July 20, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jayllyz Jayllyz

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jayllyz @userMeh