fix: QA fixes for theming/dark mode #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive text component for inner texts.
|
This one:
Could any of you please look at the patch and see if I perhaps did something wrong? 🤔 |
cbrevik
approved these changes
Oct 28, 2020
src/screens/Assistant/ResultItem.tsx
Outdated
Comment on lines
325
to
330
| <ThemeText> | ||
| <ThemeText style={{marginRight: 12, fontWeight: 'bold'}}> | ||
| {leg.line?.publicCode} | ||
| </Text>{' '} | ||
| <Text numberOfLines={1}>{name}</Text> | ||
| </Text> | ||
| </ThemeText>{' '} | ||
| <ThemeText numberOfLines={1}>{name}</ThemeText> | ||
| </ThemeText> |
src/screens/Nearby/NearbyResults.tsx
Outdated
| {publicCode && ( | ||
| <Text style={{fontWeight: 'bold'}}>{publicCode} </Text> | ||
| <ThemeText style={{fontWeight: 'bold'}}> |
There was a problem hiding this comment.
Should be normal Text-element to inherit? Unsure?
There was a problem hiding this comment.
Seems like I missed one here
There was a problem hiding this comment.
Seems I missed some of the nested texts after all. I'll go over them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Themed text on result messages / messagebox
Theme color for icon used in button component
Text style inheritance: Where text is nested, only the outer text should be of the theme text wrapper component type. Inner text should be wrapped in React native Text component to ensure they inherit styles defined for the the text wrapper container
Possible fix for colorScheme not updating on Android, by providing a patch to React native with these changes: Addressing various issues with the Appearance API (#28823) facebook/react-native#29106 (as mentioned in this issue: Appearance module does not behave correctly: addChangeListener does not react to changes, useColorScheme() does not react to changes. facebook/react-native#28823). Doesn't seem to work, though..
Theming on adding/editing favorites, and for emojis!