Skip to content

Update binaryen #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Aug 26, 2022
Merged

Update binaryen #2461

merged 24 commits into from
Aug 26, 2022

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Aug 24, 2022 •
edited
Loading

  • Update Binaryen's API with multi-memory changes
  • Refactor memory and table setup for compiler
  • Also this Binaryen release fix GUFA issue with premature optimization of exported mutable globals
  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey marked this pull request as ready for review August 24, 2022 05:59
@MaxGraey MaxGraey requested a review from dcodeIO August 24, 2022 05:59
@MaxGraey MaxGraey added enhancement dependencies Pull requests that update a dependency file labels Aug 24, 2022
@MaxGraey MaxGraey mentioned this pull request Aug 24, 2022
Closed
dcodeIO
dcodeIO reviewed Aug 26, 2022
View reviewed changes
dcodeIO
dcodeIO reviewed Aug 26, 2022
View reviewed changes
src/compiler.ts
Comment on lines +370 to +373
/** Name of the memory instance, if exported. */
export const Memory = "memory";
/** Name of the table instance, if exported. */
export const Table = "table";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What consideration were there to make these uppercase? I think in all other places we are just using lowercase names.

Copy link
Member Author

@MaxGraey MaxGraey Aug 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strict preference. But I think we should normalize everything to CamelCase-style all enums / namespaced constants similar to UnaryOp.Eqz32 and others

@MaxGraey MaxGraey merged commit 665b937 into AssemblyScript:main Aug 26, 2022
@MaxGraey MaxGraey deleted the update-binaryen branch August 26, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO