fix: --use cause compile crash (#2225) #2227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcodeIO
reviewed
Mar 18, 2022
| @@ -184,6 +184,7 @@ | |||
| "Type '{0}' has no call signatures.": 2757, | |||
|
|
|||
| "File '{0}' not found.": 6054, | |||
| "no such global element: '{0}'":6055, | |||
There was a problem hiding this comment.
Diagnostic 6055 is different in TypeScript, and we try to prevent collisions there. What seems to fit, though, is to renumber this diagnostic to 110 and move it up to the 1XX range of custom AS compiler errors.
Error ranges are about:
- 100-199: Custom AS compiler errors
- 200-899: Custom AS compilation diagnostics
- 900-999: Pedantic diagnostics
- 1000+: Reused TypeScript errors
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⯈ change error to diagnostic message ( issue #2225 )