Refactor pass pipeline for better precompute globals #2154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think this is worth it given the regressions? |
|
Well, recent commit minimize side effects |
MaxGraey
commented
Nov 23, 2021
Comment on lines
-999
to
-1006
| (local $3 i32) | ||
| (local $4 i32) | ||
| (local $5 i32) | ||
| (local $6 i32) | ||
| (local $7 i32) | ||
| (local $8 i32) | ||
| (local $9 i32) | ||
| (local $10 i32) |
There was a problem hiding this comment.
That's really good stuff
MaxGraey
commented
Nov 23, 2021
Comment on lines
-999
to
-1005
| (local $3 i32) | ||
| (local $4 i32) | ||
| (local $5 i32) | ||
| (local $6 i32) | ||
| (local $7 i32) | ||
| (local $8 i32) | ||
| (local $9 i32) |
MaxGraey
commented
Nov 23, 2021
Comment on lines
-53
to
-81
| (func $export:possibly-null/testFalseElse (param $0 i32) | ||
| global.get $~lib/memory/__stack_pointer | ||
| i32.const 4 | ||
| i32.sub | ||
| global.set $~lib/memory/__stack_pointer | ||
| global.get $~lib/memory/__stack_pointer | ||
| i32.const 1024 | ||
| i32.lt_s | ||
| if | ||
| i32.const 17440 | ||
| i32.const 17488 | ||
| i32.const 1 | ||
| i32.const 1 | ||
| call $~lib/builtins/abort | ||
| unreachable | ||
| end | ||
| global.get $~lib/memory/__stack_pointer | ||
| local.get $0 | ||
| i32.store | ||
| block $__inlined_func$possibly-null/testFalseElse | ||
| local.get $0 | ||
| i32.eqz | ||
| br_if $__inlined_func$possibly-null/testFalseElse | ||
| end | ||
| global.get $~lib/memory/__stack_pointer | ||
| i32.const 4 | ||
| i32.add | ||
| global.set $~lib/memory/__stack_pointer | ||
| ) |
MaxGraey
commented
Nov 23, 2021
Comment on lines
-14396
to
-14448
| (local $15 i32) | ||
| (local $16 i32) | ||
| (local $17 i32) | ||
| (local $18 i32) | ||
| (local $19 i32) | ||
| (local $20 i32) | ||
| (local $21 i32) | ||
| (local $22 i32) | ||
| (local $23 i32) | ||
| (local $24 i32) | ||
| (local $25 i32) | ||
| (local $26 i32) | ||
| (local $27 i32) | ||
| (local $28 i32) | ||
| (local $29 i32) | ||
| (local $30 i32) | ||
| (local $31 i32) | ||
| (local $32 i32) | ||
| (local $33 i32) | ||
| (local $34 i32) | ||
| (local $35 i32) | ||
| (local $36 i32) | ||
| (local $37 i32) | ||
| (local $38 i32) | ||
| (local $39 i32) | ||
| (local $40 i32) | ||
| (local $41 i32) | ||
| (local $42 i32) | ||
| (local $43 i32) | ||
| (local $44 i32) | ||
| (local $45 i32) | ||
| (local $46 i32) | ||
| (local $47 i32) | ||
| (local $48 i32) | ||
| (local $49 i32) | ||
| (local $50 i32) | ||
| (local $51 i32) | ||
| (local $52 i32) | ||
| (local $53 i32) | ||
| (local $54 i32) | ||
| (local $55 i32) | ||
| (local $56 i32) | ||
| (local $57 i32) | ||
| (local $58 i32) | ||
| (local $59 i32) | ||
| (local $60 i32) | ||
| (local $61 i32) | ||
| (local $62 i32) | ||
| (local $63 i32) | ||
| (local $64 i32) | ||
| (local $65 i32) | ||
| (local $66 i32) | ||
| (local $67 i32) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #2153