Skip to content

BREAKING CHANGE: Flatten generated TypeScript definitions #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2021

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented May 27, 2021

Generated TypeScript definitions for WebAssembly modules are now flat, that is do not export default ASModule anymore, but the module members directly, with the ASModule namespace removed.

fixes #1705

  • I've read the contributing guidelines

@dcodeIO dcodeIO merged commit 6540a2d into master May 27, 2021
@jerrygreen
Copy link

It’s better to merge parent PR (#1705) because in addition to fixing how .d.ts is generated, it also:

  1. Has tests
  2. Actually runs tsc, so in cases where definitions are not found by some reason, maybe due to changes to AssemblyScript compiler, or to TypeScript compiler, a test will fail
  3. Also runs some simple code after importing in tests, checking both static and dynamic types of imports, making sure it can find related functions using the flat structure

@dcodeIO dcodeIO deleted the flatten-dts branch June 1, 2021 15:20
@dcodeIO dcodeIO mentioned this pull request Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants