fix: rest parameter crash resolver (#2748)

Fixes #2707
AssemblyScript · Oct 7, 2023 · e3e4166 · e3e4166
1 parent a27258d
commit e3e4166
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/src/resolver.ts b/src/resolver.ts
@@ -392,7 +392,7 @@ export class Resolver extends DiagnosticEmitter {
           break;
         }
         case ParameterKind.Rest: {
-          assert(i == numParameters);
+          assert(i == numParameters - 1);
           hasRest = true;
           break;
         }

diff --git a/tests/compiler/issues/2707.json b/tests/compiler/issues/2707.json
@@ -0,0 +1,7 @@
+{
+  "asc_flags": [],
+  "stderr": [
+    "AS100: Not implemented: Rest parameters",
+    "func(1, 2, 3, 4);"
+  ]
+}
diff --git a/tests/compiler/issues/2707.ts b/tests/compiler/issues/2707.ts
@@ -0,0 +1,6 @@
+// should not crash
+let func: (...args: i32[]) => i32 = (...args: i32[]) => {
+  return 1;
+};
+
+func(1, 2, 3, 4);