Skip to content

Commit b24925c

Browse files
authored
fix: Support optional parameters in d.ts generation (#1665)
1 parent eb36166 commit b24925c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/definitions.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -459,11 +459,11 @@ export class TSDBuilder extends ExportsWalker {
459459
sb.push("(");
460460
var parameters = signature.parameterTypes;
461461
var numParameters = parameters.length;
462-
// var requiredParameters = signature.requiredParameters;
462+
var requiredParameters = signature.requiredParameters;
463463
for (let i = 0; i < numParameters; ++i) {
464464
if (i) sb.push(", ");
465-
// if (i >= requiredParameters) sb.push("optional ");
466465
sb.push(element.getParameterName(i));
466+
if (i >= requiredParameters) sb.push("?");
467467
sb.push(": ");
468468
sb.push(this.typeToString(parameters[i]));
469469
}

0 commit comments

Comments
 (0)