Skip to content

Commit 87cf3e8

Browse files
authored
remove experimental bigint v8 flags (#2076)
1 parent 9ffab6a commit 87cf3e8

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ jobs:
123123
run: npm run clean
124124
- name: Test experimental features
125125
env:
126-
ASC_FEATURES: mutable-globals,threads,reference-types,bigint-integration,gc
126+
ASC_FEATURES: threads,reference-types,bigint-integration,gc
127127
run: |
128128
npm run test:compiler rt/flags features/js-bigint-integration features/reference-types features/threads std-wasi/process std-wasi/crypto
129129
test-runtimes:

tests/compiler.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -342,15 +342,13 @@ function runTest(basename) {
342342
}
343343
let rtracedBuffer = stdout.toBuffer();
344344
const instantiateRtrace = section("instantiate rtrace");
345-
v8.setFlagsFromString("--experimental-wasm-bigint");
346345
if (!testInstantiate(basename, rtracedBuffer, glue, stderr, config.asc_wasi)) {
347346
failed = true;
348347
failedTests.add(basename);
349348
instantiateRtrace.end(FAILURE);
350349
} else {
351350
instantiateRtrace.end(SUCCESS);
352351
}
353-
v8.setFlagsFromString("--no-experimental-wasm-bigint");
354352
});
355353
});
356354
if (failed) return 1;

tests/features.json

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
{
22
"mutable-globals": {
33
},
4+
"bigint-integration": {
5+
},
46
"nontrapping-f2i": {
57
"asc_flags": [
68
"--enable nontrapping-f2i"
@@ -40,11 +42,6 @@
4042
"--experimental-wasm-gc"
4143
]
4244
},
43-
"bigint-integration": {
44-
"v8_flags": [
45-
"--experimental-wasm-bigint"
46-
]
47-
},
4845
"exception-handling": {
4946
"asc_flags": [
5047
"--enable exception-handling"

0 commit comments

Comments
 (0)