fix: Defuse assertion when mixing managed and unmanaged classes (#2071)

Author: dcodeIO

src/builtins.ts

@@ -9614,7 +9614,10 @@ function ensureVisitMembersOf(compiler: Compiler, instance: Class): void {
   );
 
   // And make sure the base visitor function exists
-  if (base) ensureVisitMembersOf(compiler, base);
+  if (base && base.type.isManaged) {
+    // errored earlier if not managed
+    ensureVisitMembersOf(compiler, base);
+  }
 }
 
 /** Compiles the `__visit_members` function. */

tests/compiler/unmanaged-errors.json

@@ -0,0 +1,9 @@
+{
+  "asc_flags": [
+  ],
+  "stderr": [
+    "AS207: Unmanaged classes cannot extend managed classes and vice-versa.", "UnmanagedFoo extends ManagedBase",
+    "AS207: Unmanaged classes cannot extend managed classes and vice-versa.", "ManagedFoo extends UnmanagedBase",
+    "EOF"
+  ]
+}

tests/compiler/unmanaged-errors.ts

@@ -0,0 +1,12 @@
+export class ManagedBase {}
+@unmanaged export class UnmanagedFoo extends ManagedBase {} // AS207
+
+// see: https://github.com/AssemblyScript/assemblyscript/issues/2067
+
+@unmanaged export class UnmanagedBase {}
+export class ManagedBaz {}
+export class ManagedFoo extends UnmanagedBase { // AS207
+  constructor(public baz: ManagedBaz) { super(); }
+}
+
+ERROR("EOF");