Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override automatically added arguments to test-script #397

Open
rlaferla opened this issue Oct 6, 2023 · 1 comment
Open

Override automatically added arguments to test-script #397

rlaferla opened this issue Oct 6, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@rlaferla
Copy link

rlaferla commented Oct 6, 2023

Describe a bug

The action is automatically adding arguments to the test-script but they may not be valid.

e.g. when using vitest instead of jest

> vitest run --coverage --ci --json --coverage --testLocationInResults --outputFile=report.json
          throw new CACError(`Unknown option \`${name.length > 1 ? `--${name}` : `-${name}`}\``);
                ^
CACError: Unknown option `--ci`

and

Error: A boolean argument "--coverage" was used with dot notation arguments "--coverage.enabled --coverage.reporter=json".
Please specify the "--coverage" argument with dot notation as well: "--coverage.enabled"

Expected behavior

I expected it to not add args or give me a way to override them.

Details

  • Action version: v2

  • OS, where your action is running (windows, linux): GitHub linux

  • action.yml file
    ```yml
    
    • name: Unit Test 🧪 [WebUI]
      uses: ArtiomTr/jest-coverage-report-action@v2
      with:
      test-script: npm run test:coverage
      threshold: 85
      working-directory: 'frontend/apps/web-ui' ```
@rlaferla rlaferla added the bug Something isn't working label Oct 6, 2023
@realioseb
Copy link

any updates on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants