Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android fix for border radius hides last separator #66

Closed
randycoulman opened this issue Feb 1, 2017 · 3 comments · Fixed by #75
Closed

Android fix for border radius hides last separator #66

randycoulman opened this issue Feb 1, 2017 · 3 comments · Fixed by #75

Comments

@randycoulman
Copy link
Contributor

After upgrading to 0.14.0, we noticed that the last separator in our SegmentedControls was no longer showing on Android. iOS continues to work fine.

0.13.0:
screen shot 2017-02-01 at 1 48 36 pm

0.14.0:
screen shot 2017-02-01 at 1 46 48 pm

After some digging and debugging, what appears to be happening is that the addition of the borderRadius* properties to the right edge of the last option is also clipping the border on the left.

This appears to be caused by facebook/react-native#11042.

As a result, it may be best to just wait for an upstream fix (facebook/react-native#11706), but there may be some kind of workaround we could do here until that happens.

One idea I have is to apply the separator style properties to the right border of the next-to-last option, rather than the left border of the last option. This is an ugly hack, but would work around the issue.

@wuxudong
Copy link

facebook/react-native#11706 is already closed.

and I update react-native to 0.42.0, but the problem still exists ?

@America-first-melon
Copy link

@wuxudong fixed?

@Rawphs
Copy link

Rawphs commented May 26, 2017

Setting containerBorderRadius to zero is a workaround if you don't mind having square buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants