Feature/debugger #40
Feature/debugger #40
Conversation
There was a problem hiding this comment.
With the current intention of this I suggest the module name DebugUI instead of Debugger to avoid any confusion on what this is for and how it can be used.
The fully qualified name would be CF.DebugUI / CF_DebugUI
Also, where is the logic that opens the GUI and maintains data updates?
| { | ||
| if (m_Entries[i].Key == "") m_Entries[i].Key = " "; | ||
| if (m_Entries[i].Value == "") m_Entries[i].Value = " "; | ||
| GetTemplateController().EntryKeys = GetTemplateController().EntryKeys + m_Entries[i].Key + "\n"; |
There was a problem hiding this comment.
GetTemplateController().EntryKeys is fetched twice, but wasn't it overridden in line 93? So shouldn't it just be "" or delete completly?
| { | ||
| return "JM/CF/Debugger/layouts/Debugger_Block.layout"; | ||
| } | ||
| }; No newline at end of file |
There was a problem hiding this comment.
Please add one empty line at the end of each text file for git. e.g.
class Name
{
};
| Retrieves the Debugger block if it exists based on the name and if specified, the target. | ||
| Creates a new block if no existing block was found. | ||
| */ | ||
| Class Get(string name, Object target = null) |
There was a problem hiding this comment.
Why is class returned and not a block type?
| /* | ||
| Get all blocks by name, if no name specified, get all blocks | ||
| */ | ||
| array<Class> GetAll(string name = "") |
There was a problem hiding this comment.
Same as above, why an array of classes and not an array of blocks
| { | ||
| m_Blocks = new array<ref CF_Debugger_Block>(); | ||
|
|
||
| m_IsEnabled = FileExist("$profile:CF_Debugger.txt"); |
There was a problem hiding this comment.
Why does it need this file? There should be a way to enable and disable this purely via script and or startup parameter?
e.g. DayZ.exe -CF_DebugUI
| hexactsize 0 | ||
| vexactsize 0 | ||
| scriptclass "ViewBinding" | ||
| text "deserunt mollit anim id est laborum.\""\ |
There was a problem hiding this comment.
Can we remove this sample text for the release and just replace it with a short "PLACEHOLDER"?
| CF_Permission_ManagerBase._Init( Permission ); | ||
| #endif | ||
|
|
||
| Debugger = new CF_Debugger(); |
There was a problem hiding this comment.
Why is this on world init and not game init? Is it because of UI components?
|
|
||
| class CF_Debugger | ||
| { | ||
| private autoptr array<ref CF_Debugger_Block> m_Blocks; |
There was a problem hiding this comment.
I think we should use protected. I see no reason why someone could not inherit their own variant and replace their local CF.Debugger instance at runtime with their own type.
| @@ -0,0 +1,5 @@ | |||
| class CF_Debugger_Block_Controller: Controller | |||
| { | |||
| string EntryKeys; | |||
There was a problem hiding this comment.
Keys = plural? How are multiple keys stored here?
| */ | ||
| static void _Cleanup() | ||
| { | ||
| delete Debugger; |
There was a problem hiding this comment.
No cleanup required? To safely close UI and delete all data?
No description provided.