feat: remove target and rel from internal link (#16)

alfonsobries · web-flow · commit 4b0cbaac38e4 · 2021-06-29T17:15:43.000+02:00
diff --git a/src/Extensions/Link/LinkRenderer.php b/src/Extensions/Link/LinkRenderer.php
@@ -2,6 +2,7 @@
 
 namespace ARKEcosystem\CommonMark\Extensions\Link;
 
+use Illuminate\Support\Arr;
 use Illuminate\View\ComponentAttributeBag;
 use League\CommonMark\ElementRendererInterface;
 use League\CommonMark\HtmlElement;
@@ -47,7 +48,7 @@ public function render(AbstractInline $inline, ElementRendererInterface $htmlRen
         }
 
         if ($this->isInternalLink($attrs['href'])) {
-            $attrs = array_merge($attrs, config('markdown.link_attributes', []));
+            $attrs = array_merge(Arr::only($attrs, ['href', 'id', 'class', 'name', 'title']), config('markdown.link_attributes', []));
 
             return new HtmlElement('a', $attrs, $htmlRenderer->renderInlines($inline->children()));
         }

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace ARKEcosystem\CommonMark\Extensions\Link;`
`4`	`4`
	`5`	`+use Illuminate\Support\Arr;`
`5`	`6`	`use Illuminate\View\ComponentAttributeBag;`
`6`	`7`	`use League\CommonMark\ElementRendererInterface;`
`7`	`8`	`use League\CommonMark\HtmlElement;`
`@@ -47,7 +48,7 @@ public function render(AbstractInline $inline, ElementRendererInterface $htmlRen`
`47`	`48`	`}`
`48`	`49`
`49`	`50`	`if ($this->isInternalLink($attrs['href'])) {`
`50`		`- $attrs = array_merge($attrs, config('markdown.link_attributes', []));`
	`51`	`+ $attrs = array_merge(Arr::only($attrs, ['href', 'id', 'class', 'name', 'title']), config('markdown.link_attributes', []));`
`51`	`52`
`52`	`53`	`return new HtmlElement('a', $attrs, $htmlRenderer->renderInlines($inline->children()));`
`53`	`54`	`}`