Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-p2p): rate limit plugin #4193

Merged
merged 2 commits into from
Nov 24, 2020
Merged

feat(core-p2p): rate limit plugin #4193

merged 2 commits into from
Nov 24, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Nov 24, 2020

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #4193 (fafa548) into develop (a238981) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4193   +/-   ##
========================================
  Coverage    95.67%   95.67%           
========================================
  Files          734      735    +1     
  Lines        17741    17760   +19     
  Branches      2171     2172    +1     
========================================
+ Hits         16973    16992   +19     
  Misses         597      597           
  Partials       171      171           
Flag Coverage Δ
functional 5.91% <0.00%> (-0.01%) ⬇️
integration 9.74% <0.00%> (-0.02%) ⬇️
unit 94.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/core-p2p/src/socket-server/plugins/rate-limit.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/socket-server/server.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a238981...fafa548. Read the comment docs.

@air1one air1one marked this pull request as ready for review November 24, 2020 09:26
@faustbrian faustbrian merged commit 21eb71a into develop Nov 24, 2020
@faustbrian faustbrian deleted the feat/p2p-rate-limit branch November 24, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants