-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core-transaction-pool): better locking #3802
Merged
faustbrian
merged 8 commits into
develop
from
refactor/core-transaction-pool/sender-mempool-locks
Jun 17, 2020
Merged
refactor(core-transaction-pool): better locking #3802
faustbrian
merged 8 commits into
develop
from
refactor/core-transaction-pool/sender-mempool-locks
Jun 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Medium
labels
Jun 15, 2020
Codecov Report
@@ Coverage Diff @@
## develop #3802 +/- ##
===========================================
+ Coverage 96.92% 97.09% +0.16%
===========================================
Files 616 617 +1
Lines 13999 13955 -44
Branches 1688 1685 -3
===========================================
- Hits 13569 13549 -20
+ Misses 137 117 -20
+ Partials 293 289 -4
Continue to review full report at Codecov.
|
rainydio
changed the title
refactor(core-transaction-pool): better locking in sender mempool
refactor(core-transaction-pool): better locking
Jun 16, 2020
faustbrian
approved these changes
Jun 17, 2020
ghost
deleted the
refactor/core-transaction-pool/sender-mempool-locks
branch
June 17, 2020 02:52
ghost
removed
the
Status: Needs Review
label
Jun 17, 2020
ghost
mentioned this pull request
Jun 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3800
New general-purpose
Lock
class is added tocore-kernel
utils to facilitate pool synchronization:In general this kind of locking is traditionally used in databases. Read-only transactions can run in parallel, write transactions require all read-only transactions to finish and then lock database until finished. Technique itself is more general and can be applied in non-database scenarios.
Several synchronization issues are fixed in pool:
Checklist