Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-manager): implement events listener and events database #3754

Merged
merged 13 commits into from
Jun 1, 2020

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented May 29, 2020

Summary

This PR includes initial watcher functionality described in #3753.

Logic

Package uses SQLite database for storage using BetterSqlite3 package. Database is saved to default location and contains following columns:

  • id
  • event name
  • event data
  • timestamp

Database exposes query method to fetch events based on query conditions. For now those are:

  • limit
  • offset
  • event name (using LIKE % matching)

Event listener is responsible for capturing node events and saving them to database.

Checklist

  • Tests
  • Ready to be merged

@ghost ghost added the Complexity: High label May 29, 2020
@sebastijankuzner sebastijankuzner changed the title Feat/core watchers feat(core-watcher): implement package basic logic with database May 29, 2020
Copy link
Contributor

@faustbrian faustbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As previously discussed this functionality will be part of core-manager and not a separate package due to how it will be consumed. Will review it after they have been merged.

@sebastijankuzner sebastijankuzner changed the title feat(core-watcher): implement package basic logic with database feat(core-manager): implement events listener and events database May 29, 2020
@faustbrian faustbrian merged commit 29672aa into develop Jun 1, 2020
@ghost ghost deleted the feat/core-watchers branch June 1, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants