-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core-manager): implement events listener and events database #3754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastijankuzner
requested review from
air1one,
faustbrian and
kristjank
as code owners
May 29, 2020 10:46
ghost
added
the
Complexity: High
label
May 29, 2020
sebastijankuzner
changed the title
Feat/core watchers
feat(core-watcher): implement package basic logic with database
May 29, 2020
faustbrian
suggested changes
May 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As previously discussed this functionality will be part of core-manager
and not a separate package due to how it will be consumed. Will review it after they have been merged.
sebastijankuzner
changed the title
feat(core-watcher): implement package basic logic with database
feat(core-manager): implement events listener and events database
May 29, 2020
ghost
mentioned this pull request
May 31, 2020
ghost
deleted the
feat/core-watchers
branch
June 1, 2020 06:04
ghost
mentioned this pull request
Jun 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes initial watcher functionality described in #3753.
Logic
Package uses SQLite database for storage using BetterSqlite3 package. Database is saved to default location and contains following columns:
Database exposes query method to fetch events based on query conditions. For now those are:
Event listener is responsible for capturing node events and saving them to database.
Checklist