Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-state): merge index and reindex into one function inside WalletRepository #3563

Merged
merged 2 commits into from
Mar 2, 2020

Conversation

bertiespell
Copy link
Contributor

Summary

Condense index and reindex into one method.

Only one index method means the naming is better. Smaller API (public methods on class) = simpler code.

The index and reindex methods were condensed into one method - index, which accepts either a wallet or an array of wallets.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@bertiespell bertiespell changed the title test(core-state): merge index and reindex into one function inside Wa… test(core-state): merge index and reindex into one function inside WalletRepository Mar 2, 2020
@faustbrian faustbrian changed the title test(core-state): merge index and reindex into one function inside WalletRepository refactor(core-state): merge index and reindex into one function inside WalletRepository Mar 2, 2020
@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #3563 into develop will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3563      +/-   ##
===========================================
- Coverage    56.89%   56.89%   -0.01%     
===========================================
  Files          548      548              
  Lines        13661    13663       +2     
  Branches      1867     1868       +1     
===========================================
  Hits          7773     7773              
- Misses        5859     5861       +2     
  Partials        29       29              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64403cd...ad3b558. Read the comment docs.

@faustbrian faustbrian merged commit af2d8dc into develop Mar 2, 2020
@ghost ghost deleted the refactor/core-state-indexes branch March 2, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants