-
Notifications
You must be signed in to change notification settings - Fork 285
fix(core-p2p): handle p2p edge cases #3412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as we cant validate with ajv in worker for transactions implemented a "light validation" to quickly discard wrong data this will need to be reworked with p2p for v3
This reverts commit eb021e9.
Codecov Report
@@ Coverage Diff @@
## develop #3412 +/- ##
==========================================
- Coverage 66.34% 66.1% -0.24%
==========================================
Files 439 439
Lines 12345 12456 +111
Branches 1676 1705 +29
==========================================
+ Hits 8190 8234 +44
- Misses 4123 4189 +66
- Partials 32 33 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
checkNetworkHealth
less deterministicallyChecklist