Skip to content

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Jan 21, 2020

Summary

  • Discard blocks containing too many transactions
  • Disconnect when multiple sockets are opened from same IP
  • Handle invalid WS opcodes
  • Disconnect for p2p SocketCluster events that do not have a handler
  • Handle payload with additional properties
  • Use shared rate limiter for defined endpoints only
  • call checkNetworkHealth less deterministically

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

Merging #3412 into develop will decrease coverage by 0.23%.
The diff coverage is 29.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #3412      +/-   ##
==========================================
- Coverage    66.34%   66.1%   -0.24%     
==========================================
  Files          439     439              
  Lines        12345   12456     +111     
  Branches      1676    1705      +29     
==========================================
+ Hits          8190    8234      +44     
- Misses        4123    4189      +66     
- Partials        32      33       +1
Impacted Files Coverage Δ
packages/core-p2p/src/network-monitor.ts 73.46% <100%> (+0.1%) ⬆️
packages/core-p2p/src/socket-server/errors.ts 76.92% <100%> (+40.55%) ⬆️
...ckages/core-p2p/src/socket-server/versions/peer.ts 65.51% <100%> (+2.55%) ⬆️
...es/core-p2p/src/socket-server/versions/internal.ts 93.18% <100%> (-6.82%) ⬇️
packages/core-p2p/src/rate-limiter.ts 100% <100%> (ø) ⬆️
packages/core-p2p/src/socket-server/worker.ts 24.45% <20.68%> (+4.45%) ⬆️
...kages/core-p2p/src/socket-server/utils/validate.ts 25% <6.25%> (-75%) ⬇️
...kages/core-p2p/src/socket-server/versions/utils.ts 88.88% <75%> (-4.45%) ⬇️
packages/core-blockchain/src/blockchain.ts 65.87% <80%> (+3.19%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2824ac6...2ccc33e. Read the comment docs.

@faustbrian faustbrian merged commit 1d3614d into develop Jan 21, 2020
@ghost ghost deleted the develop-patch-p2p branch January 21, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants