-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core-database-postgres): add nonce column #2844
Conversation
Your pull request doesn't follow our contribution guidelines. Please review and correct it. |
This pull request introduces 1 alert when merging 4ec0d7f into 757b7f5 - view on LGTM.com new alerts:
|
The migration also needs to be executed. |
…o-db * ArkEcosystem/core/2.6: feat(core-state): wallet manager indexes (#2845)
The nonce also needs to be added to the database model here: https://github.com/ArkEcosystem/core/blob/2.6/packages/core-database-postgres/src/models/transaction.ts#L7 |
Done: f5fc1a5 |
* Migrate existent v1 transactions by setting their nonce accordingly * Set a trigger to transparently set the nonce field on newly inserted v1 transactions
…o-db * ArkEcosystem/core/2.6: refactor(core-state): expose current block for transaction handlers (#2856)
…o-db * ArkEcosystem/core/2.6: release: 2.5.0-next.10 (#2852) fix(core-p2p): ensure payload database exists (#2851) release: 2.5.14 release: 2.5.14 (#2849) fix(core-p2p): peer discovery limit (#2850) perf(core-p2p): improve transactions endpoint (#2848) fix(core-api): internal server error caused by invalid orderBy field (#2847) refactor(core-p2p): increase network timeouts (#2828) fix(core-api): return data directly if cache is disabled (#2831) fix(core-utils): add content-type header (#2840) perf(core-database): lookup delegates by key (#2837)
…o-db * ArkEcosystem/core/2.6: refactor(core-transactions): make handler functions asynchronous (#2865) fix: merge fix: delete existing db (#2864) fix: clone webhook before mutating it (#2863) fix: delete existing db fix: clone webhook before mutating it fix(core-state): differentiate between wallets and delegates (#2854) fix(core-state): differentiate between wallets and delegates (#2854) refactor: increase transaction type size (#2861)
The only remaining failure is:
That test passes when I run it locally:
I think this test fails sporadically and its failure is not related to the patch in this pull request. |
A summary of what changes this PR introduces and why they were made.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
develop
branch, not themaster
branchIf adding a new feature, the PR's description includes: