Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify tests #738

Closed
2 tasks
j-a-m-l opened this issue Jul 6, 2018 · 5 comments
Closed
2 tasks

Unify tests #738

j-a-m-l opened this issue Jul 6, 2018 · 5 comments
Assignees

Comments

@j-a-m-l
Copy link
Contributor

j-a-m-l commented Jul 6, 2018

Currently we don't have a unified way to test all the packages: some of them are using core-test-utils or have received more love than others.

  • Refactor to create more custom matchers
  • Refactor to remove duplicated fixtures (genesisBlock.json, etc.)
@j-a-m-l j-a-m-l mentioned this issue Jul 6, 2018
1 task
@j-a-m-l
Copy link
Contributor Author

j-a-m-l commented Jul 14, 2018

I've updated this issue to defined several specific tasks. Suggestions are welcomed.

@faustbrian
Copy link
Contributor

Any progress on this? Has already been a month.

@j-a-m-l j-a-m-l self-assigned this Aug 3, 2018
@j-a-m-l
Copy link
Contributor Author

j-a-m-l commented Aug 3, 2018

I've been working on #783 to fix some problems that affect almost all of the packages that require setting up a blockchain. When that it's finished, I will continue with these points.

@faustbrian faustbrian assigned air1one and unassigned j-a-m-l Aug 20, 2018
@faustbrian
Copy link
Contributor

@air1one will take over all testing related tasks on core now.

@air1one
Copy link
Contributor

air1one commented Oct 5, 2018

I think we can close this as I did a first good refactoring across the packages, using core-test-utils when useful. (also refactored core-test-utils itself).

Also wrote a doc to explain how our tests are structured and how to add / update tests for anyone to be able to do so : see here ArkEcosystem/docs#52 (PR being reviewed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants