Remove state=blockchain tag from block state (#3828)

Author: rainydio

__tests__/unit/core-state/setup.ts

@@ -278,7 +278,7 @@ export const setUp = async (setUpOptions = setUpDefaults, skipBoot = false): Pro
         Container.Identifiers.DposPreviousRoundStateProvider,
     );
 
-    const blockState = sandbox.app.get<BlockState>(Container.Identifiers.BlockState);
+    const blockState = sandbox.app.getTagged<BlockState>(Container.Identifiers.BlockState, "state", "blockchain");
 
     const dPosState = sandbox.app.getTagged<DposState>(Container.Identifiers.DposState, "state", "blockchain");
 

packages/core-state/src/block-state.ts

@@ -5,12 +5,7 @@ import { Enums, Identities, Interfaces, Utils } from "@arkecosystem/crypto";
 // todo: review the implementation and make use of ioc
 @Container.injectable()
 export class BlockState {
-    // @Container.inject(Container.Identifiers.Application)
-    // private readonly app!: Contracts.Kernel.Application;
-
     @Container.inject(Container.Identifiers.WalletRepository)
-    @Container.tagged("state", "blockchain") // TODO: Without this line - and despite
-    // being intialised in the same way as the service provider - the tests fail to find a correct binding
     private walletRepository!: Contracts.State.WalletRepository;
 
     @Container.inject(Container.Identifiers.TransactionHandlerRegistry)