Skip to content

Commit 2d3b05f

Browse files
author
Brian Faust
committed
style(core-kernel): consistent naming for plugin resources
1 parent 56850c5 commit 2d3b05f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+413
-389
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "stub-package-with-defaults",
2+
"name": "stub-plugin-with-defaults",
33
"version": "1.0.0",
44
"main": "dist/index"
55
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "stub-package",
2+
"name": "stub-plugin",
33
"version": "1.0.0",
44
"main": "dist/index"
55
}

__tests__/unit/core-kernel/bootstrap/app/load-service-providers.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ afterEach(() => container.restore());
3232
describe("LoadServiceProviders", () => {
3333
it("should bootstrap with defaults", async () => {
3434
configRepository = new ConfigRepository({
35-
packages: [{ package: resolve(__dirname, "../../__stubs__/stub-package-with-defaults") }],
35+
plugins: [{ package: resolve(__dirname, "../../__stubs__/stub-plugin-with-defaults") }],
3636
});
3737

3838
app.bind(Identifiers.ConfigRepository).toConstantValue(configRepository);
@@ -44,7 +44,7 @@ describe("LoadServiceProviders", () => {
4444

4545
it("should bootstrap without defaults", async () => {
4646
configRepository = new ConfigRepository({
47-
packages: [{ package: resolve(__dirname, "../../__stubs__/stub-package") }],
47+
plugins: [{ package: resolve(__dirname, "../../__stubs__/stub-plugin") }],
4848
});
4949

5050
app.bind(Identifiers.ConfigRepository).toConstantValue(configRepository);

__tests__/unit/core-kernel/bootstrap/service-providers/__stubs__/service-providers.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import Joi from "@hapi/joi";
2-
import { PackageDependency } from "@packages/core-kernel/src/contracts/kernel";
2+
import { PluginDependency } from "@packages/core-kernel/src/contracts/kernel";
33
import { ServiceProvider } from "@packages/core-kernel/src/providers";
44

55
export class StubServiceProvider extends ServiceProvider {
@@ -83,7 +83,7 @@ export class RequiredDependencyCannotBeFoundServiceProvider extends ServiceProvi
8383
return "stub";
8484
}
8585

86-
public dependencies(): PackageDependency[] {
86+
public dependencies(): PluginDependency[] {
8787
return [{ name: "deps-required", required: true }];
8888
}
8989
}
@@ -95,7 +95,7 @@ export class RequiredDependencyCannotBeFoundAsyncServiceProvider extends Service
9595
return "stub";
9696
}
9797

98-
public dependencies(): PackageDependency[] {
98+
public dependencies(): PluginDependency[] {
9999
return [{ name: "deps-required", required: async () => true }];
100100
}
101101
}
@@ -107,7 +107,7 @@ export class OptionalDependencyCannotBeFoundServiceProvider extends ServiceProvi
107107
return "stub";
108108
}
109109

110-
public dependencies(): PackageDependency[] {
110+
public dependencies(): PluginDependency[] {
111111
return [{ name: "deps-optional" }];
112112
}
113113
}
@@ -119,7 +119,7 @@ export class RequiredDependencyVersionCannotBeSatisfiedServiceProvider extends S
119119
return "stub";
120120
}
121121

122-
public dependencies(): PackageDependency[] {
122+
public dependencies(): PluginDependency[] {
123123
return [{ name: "dep", version: ">=2.0.0", required: true }];
124124
}
125125
}
@@ -131,7 +131,7 @@ export class OptionalDependencyVersionCannotBeSatisfiedServiceProvider extends S
131131
return "stub";
132132
}
133133

134-
public dependencies(): PackageDependency[] {
134+
public dependencies(): PluginDependency[] {
135135
return [{ name: "dep", version: ">=2.0.0" }];
136136
}
137137
}

0 commit comments

Comments
 (0)